Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FvwmPager: Allow for some dynamic config loading #975

Closed
wants to merge 1 commit into from

Conversation

ThomasAdam
Copy link
Member

@ThomasAdam ThomasAdam commented Mar 24, 2024

This makes FvwmPager listen to 'SendToModule' commands such that the
following options can be configured on a running FvwmPager instance:

  • DeskLabels
  • NoDeskLabels
  • Monitor RANDRNAME
  • MonitorLabels
  • NoMonitorLabels

For example:

SendToModule FvwmPager Monitor $[monitor.1.name]

Will force an already-running FvwmPager instance to only track that monitor.

@ThomasAdam ThomasAdam added this to the 1.1.0 milestone Mar 24, 2024
@ThomasAdam ThomasAdam self-assigned this Mar 24, 2024
@ThomasAdam ThomasAdam force-pushed the ta/fvwmpager-sendtomodule branch from e3d1087 to be6b54f Compare March 25, 2024 17:57
@ThomasAdam ThomasAdam removed this from the 1.1.0 milestone Mar 29, 2024
@ThomasAdam ThomasAdam marked this pull request as draft March 29, 2024 18:15
@ThomasAdam
Copy link
Member Author

Before merging this, we should also consider which other settings we want to be configurable:

  • MonitorLabels
  • DeskLabels

etc, etc.

@ThomasAdam ThomasAdam added type:enhancement Augmenting an existing feature relates:module Issue is in module code labels Mar 29, 2024
@ThomasAdam ThomasAdam force-pushed the ta/fvwmpager-sendtomodule branch from be6b54f to e45b5c8 Compare April 4, 2024 19:39
@ThomasAdam ThomasAdam changed the title FvwmPager: Allow for dynamic Monitor loading FvwmPager: Allow for some dynamic config loading Apr 4, 2024
@ThomasAdam ThomasAdam added this to the 1.1.1 milestone Apr 4, 2024
@ThomasAdam ThomasAdam marked this pull request as ready for review April 4, 2024 19:42
@ThomasAdam ThomasAdam force-pushed the ta/fvwmpager-sendtomodule branch from e45b5c8 to d446eb4 Compare April 4, 2024 19:45
This makes FvwmPager listen to 'SendToModule' commands such that the
following options can be configured on a running FvwmPager instance:

* DeskLabels
* NoDeskLabels
* Monitor RANDRNAME
* MonitorLabels
* NoMonitorLabels

For example:

   SendToModule FvwmPager Monitor $[monitor.1.name]

Will force an already-running FvwmPager instance to only track that
monitor.
@ThomasAdam ThomasAdam force-pushed the ta/fvwmpager-sendtomodule branch from d446eb4 to 179131b Compare April 4, 2024 19:59
@ThomasAdam ThomasAdam added skip:changelog Issue/PR should skip CHANGELOG and removed type:enhancement Augmenting an existing feature relates:module Issue is in module code labels Apr 11, 2024
@ThomasAdam
Copy link
Member Author

Closing. To be replaced with a different PR.

@ThomasAdam ThomasAdam closed this Apr 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip:changelog Issue/PR should skip CHANGELOG
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

1 participant