FvwmMFL: fix singletion/locking mechanism #1057
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
farblos
reviewed
Aug 21, 2024
farblos
reviewed
Aug 21, 2024
| @@ -246,7 +163,7 @@ static void | |||
| HandleTerminate(int fd, short what, void *arg) | |||
| { | |||
| fprintf(stderr, "%s: dying...\n", __func__); | |||
| delete_pid_file(); | |||
| unlink(lockfile); | |||
| unlink(socket_name); | |||
| rmdir(socket_basepath); | |||
There was a problem hiding this comment.
Oh, and you probably should not just replace delete_pid_file() by unlink(lockfile), but also complement all calls to unlink(socket_name) by a call to unlink(lockfile) (plus closing the lock file handle)? There are at least two calls to unlink(socket_name) in main that do not also care about the lock file.
Or did I miss something here?
There can only ever be one single instance of FvwmMFL running per FVWM instance/$DISPLAY. Currently, this is done with logging the PID of the running FvwmMFL process and using that to look up a process with the same PID. This is fragile though as the pid in the saved file might not be the samae PID of FvwmMFL -- therefore, FvwmMFL wouldn't start. Instead, switch to using a lock file which is predicated per $DISPLAY -- achieving the same result, but less error prone. Fixes #1054
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There can only ever be one single instance of FvwmMFL running per FVWM instance/$DISPLAY.
Currently, this is done with logging the PID of the running FvwmMFL process and using that to look up a process with the same PID. This is fragile though as the pid in the saved file might not be the samae PID of FvwmMFL -- therefore, FvwmMFL wouldn't start.
Instead, switch to using a lock file which is predicated per $DISPLAY -- achieving the same result, but less error prone.
Fixes #1054