feat(detector/vuls2): detect OpenSSH security advisories - #2636
Draft
MaineK00n wants to merge 1 commit into
Draft
Conversation
MaineK00n
marked this pull request as draft
August 12, 2026 12:46
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Routes the
openssh-securitydata source (MaineK00n/vuls-data-update#928) through the vuls2 CPE detection path, so a host running OpenSSH is matched against what the upstream project itself states about each release.What
models.OpenSSHCveContentType, and theOpenSSHExactVersionMatch/OpenSSHVendorProductMatchconfidences, alongside the existing vendor sources.detector/vuls2/vendor.go: the source is advisory-shaped like Cisco, so it gets the same four hooks — theDistroAdvisoryreference,cveContentSourceLink,toCveContentTypeanddetectionMethod.detector/vuls2/vuls2.go:sourceTypes.OpenSSHSecurityjoinsverifiedCPESources.Why the link is not per-advisory
OpenSSH publishes its whole security history as a single page and assigns no per-entry URL. The advisory ID (
OPENSSH-<date>-<n>) is synthesised by the extractor to key the entry, so it is carried as theRefIDwhile the link points at https://www.openssh.com/security.html.Why it belongs in verifiedCPESources
openssh-securityis the upstream project's own statement of which releases a flaw applies to, given as a bounded range per entry. It therefore dominates a supplementary source's version-lessopenbsd:opensshmatch, in the same way the Fortinet, Cisco and Palo Alto feeds do for their products. Suppression stays keyed per CVE, so it only fires where OpenSSH has an advisory for that very CVE.Testing
go build ./...andgo test ./detector/... ./models/...pass.Independent of #2635 (Apple): the two sources touch different
SourceIDs, and this branch is based onmaster.