docs: specify order of clipping operations in ClipBam docs#1143
docs: specify order of clipping operations in ClipBam docs#1143
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review infoConfiguration used: Organization UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughThis PR adds documentation to the ClipBam tool explaining the sequence of clipping operations. The new paragraph outlines four steps: upgrade clipping, fixed 5' and 3' clippings, overlapping-read clipping, and clipping reads past their mate. The changes are purely documentary—no functional logic or control flow modifications are introduced. 🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@src/main/scala/com/fulcrumgenomics/bam/ClipBam.scala`:
- Around line 72-77: Update the clipping-order paragraph wording to use singular
grammar ("The order of operations for clipping is:") and clarify step 4 to state
that clipping bases past the mate applies only to FR pairs; reference the
existing options/flags in the code (--upgrade-clipping,
--clip-overlapping-reads, --clip-bases-past-mate) and the runtime check
(clipBasesPastMate && r1.isFrPair) so the doc text matches the implementation.
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1143 +/- ##
=======================================
Coverage 95.96% 95.96%
=======================================
Files 132 132
Lines 8037 8037
Branches 516 516
=======================================
Hits 7713 7713
Misses 324 324
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Good idea to document this order (since order does matter) from this issue: