Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] The Fulcro3 version of the the TodoMVC #3

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

abhi18av
Copy link

@abhi18av abhi18av commented Aug 12, 2019

As of now, I've just updated the app namespaces and just extracted the code from the main repo and embedded in the fulcro-template structure. The book refers to this todomvc a some points so I thought it might be a good idea to get this ported already.

I'll make further changes such as Readme, dev config etc once I've had your feedback on the necessary changes.

@@ -0,0 +1,279 @@
== The Project

WARNING: This template is in progress. The README is out of date, and at any given time it might not even be working. This
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should really edit this if you're going to add it. It talks about the wrong project.

@@ -0,0 +1,39 @@
{:paths ["src/main" "resources"]

:deps {org.clojure/clojure {:mvn/version "1.10.1"}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is waaaay more deps than are probably needed. semantic-ui-wrapper, garden-css, ghostwheel, datascript...oh wait, this was the demo I was using IN f3?

I don't think this is what I want to do with this repo....

@awkay
Copy link
Contributor

awkay commented Aug 12, 2019

So, I'd prefer not to put this in a public repo. It was a demo project for my own internal use, and isn't even really full-stack. If you wanted to rewrite the back-end and use an SQL database or something, then that might be interesting, but I'm not sure I want to even bother brining this demo project forward...esp not this way.

@awkay awkay closed this Aug 12, 2019
@abhi18av
Copy link
Author

abhi18av commented Aug 12, 2019

Hmm, the code being rough is the reason I kept it as WIP. No worries, let me put this together again after some time in a proper manner and then you can decide :)

@awkay
Copy link
Contributor

awkay commented Aug 12, 2019

Sorry, I know that is discouraging...if you are planning on fleshing it out, then that's OK...sorry about that.

@awkay awkay reopened this Aug 12, 2019
@abhi18av
Copy link
Author

Tony, I can understand how you feel about quality. I do realize that Fulcro is a project you've give so much time for and you have certain opinions and expectations about how it should be used and portrayed. I get it 👍

I do plan to take it forward and flesh things out as best as I can 😊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants