-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] The Fulcro3 version of the the TodoMVC #3
base: develop
Are you sure you want to change the base?
Conversation
@@ -0,0 +1,279 @@ | |||
== The Project | |||
|
|||
WARNING: This template is in progress. The README is out of date, and at any given time it might not even be working. This |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You should really edit this if you're going to add it. It talks about the wrong project.
@@ -0,0 +1,39 @@ | |||
{:paths ["src/main" "resources"] | |||
|
|||
:deps {org.clojure/clojure {:mvn/version "1.10.1"} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is waaaay more deps than are probably needed. semantic-ui-wrapper, garden-css, ghostwheel, datascript...oh wait, this was the demo I was using IN f3?
I don't think this is what I want to do with this repo....
So, I'd prefer not to put this in a public repo. It was a demo project for my own internal use, and isn't even really full-stack. If you wanted to rewrite the back-end and use an SQL database or something, then that might be interesting, but I'm not sure I want to even bother brining this demo project forward...esp not this way. |
Hmm, the code being rough is the reason I kept it as WIP. No worries, let me put this together again after some time in a proper manner and then you can decide :) |
Sorry, I know that is discouraging...if you are planning on fleshing it out, then that's OK...sorry about that. |
Tony, I can understand how you feel about quality. I do realize that I do plan to take it forward and flesh things out as best as I can 😊 |
As of now, I've just updated the app namespaces and just extracted the code from the main repo and embedded in the
fulcro-template
structure. The book refers to thistodomvc
a some points so I thought it might be a good idea to get this ported already.I'll make further changes such as Readme,
dev
config etc once I've had your feedback on the necessary changes.