Fix build issues related to DuckDB #852
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updates the DuckDB.NET.Bindings.Full and DuckDB.NET.Data.Full NuGet packages to version 1.3.2 in the Tests group.
Updates hardcoded NuGet package paths in the build script. This change ensures that the build script correctly references the required NuGet packages, resolving potential build failures due to incorrect paths.
Member
|
Looks ok to me. Let me know when ok to merge. Right now it bundles some package updates with the case-sensitivity fix. If it goes too complex, just separate the package updates, we can do those as a separate PR later as well. I remember there was some challenges with e.g. StructureLogger (used in build only) different versions and dependency hierarchies. |
Tom-Sloboda
changed the title
Contributor
Author
|
Split off the Firebird rename into #853 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Updates DuckDB.NET packages to v1.3.2 to fix build error.
Types of changes
What types of changes does your code introduce to SQLProvider?
Put an
xin the boxes that applyChecklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.