Skip to content

Commit 3586e6c

Browse files
committed
Remove redundant rules
- eslint-plugin-no-only-tests - eslint-plugin-no-skip-tests These rules are now implemented by jest/no-disabled-tests & jest/no-focused-tests. Update test snapshot. Release version 4.0.0.
1 parent 9748d57 commit 3586e6c

File tree

6 files changed

+18
-24
lines changed

6 files changed

+18
-24
lines changed

.eslintrc.js

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -11,8 +11,6 @@ module.exports = {
1111
// Enable plugins that are not natively supported by Code Climate. Otherwise results in build errors.
1212
'eslint-plugin-bestpractices',
1313
'eslint-plugin-deprecate',
14-
'eslint-plugin-no-only-tests',
15-
'eslint-plugin-no-skip-tests',
1614
'eslint-plugin-promise',
1715
'eslint-plugin-sonarjs',
1816
'eslint-plugin-test-selectors' // NOTE: Only runs against JSX
@@ -28,4 +26,4 @@ module.exports = {
2826
{'name': '$.each', 'use': 'native forEach'}
2927
]
3028
}
31-
}
29+
};

README.md

Lines changed: 7 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -9,8 +9,6 @@ Utilizes the following plugins:
99
- [eslint-plugin-html](https://github.com/BenoitZugmeyer/eslint-plugin-html)
1010
- [eslint-plugin-jsdoc](https://github.com/gajus/eslint-plugin-jsdoc)
1111
- [eslint-plugin-json](https://github.com/azeemba/eslint-plugin-json)
12-
- [eslint-plugin-no-only-tests](https://github.com/levibuzolic/eslint-plugin-no-only-tests)
13-
- [eslint-plugin-no-skip-tests](https://github.com/romaingaillardjs/eslint-plugin-no-skip-tests)
1412
- [eslint-plugin-promise](https://github.com/xjamundx/eslint-plugin-promise)
1513
- [eslint-plugin-sonarjs](https://github.com/SonarSource/eslint-plugin-sonarjs)
1614
- [eslint-config-standard](https://github.com/standard/eslint-config-standard)
@@ -30,7 +28,7 @@ Utilizes the following plugins:
3028

3129
1. Add this repository as a package devDependency:
3230

33-
> "eslint-config-tree": "github:fs-webdev/eslint-config-tree#semver:^2",
31+
> "eslint-config-tree": "github:fs-webdev/eslint-config-tree#semver:^4",
3432
3533
1. In your `eslintrc.js` file, put the following:
3634
<pre><code>module.exports = {
@@ -41,8 +39,6 @@ Utilizes the following plugins:
4139
plugins: [
4240
'eslint-plugin-bestpractices',
4341
'eslint-plugin-deprecate',
44-
'eslint-plugin-no-only-tests',
45-
'eslint-plugin-no-skip-tests',
4642
'eslint-plugin-promise',
4743
'eslint-plugin-sonarjs',
4844
'eslint-plugin-test-selectors'
@@ -77,6 +73,12 @@ If there has been a change (say you added a new rule, or there is a new valid vi
7773

7874
## Changelog:
7975

76+
<details>
77+
<summary>Version 4 </summary>
78+
- `eslint-plugin-no-only-tests` & `eslint-plugin-no-skip-tests` are redundant to to newly-implemented `jest/no-focused-tests` & `jest/no-disabled-tests` and have been removed.
79+
80+
</details>
81+
8082
<details>
8183
<summary>Version 3 - ESLint 7</summary>
8284

demo/test/snapshots/lint-output.js.md

Lines changed: 6 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -11,10 +11,10 @@ Generated by [AVA](https://ava.li).
1111
`␊
1212
example.js␊
1313
6:0 warning Inline eslint-disable found bestpractices/no-eslint-disable␊
14-
8:1 warning Unexpected 'FIXME' comment no-warning-comments␊
15-
9:1 warning Unexpected 'TODO' comment no-warning-comments␊
16-
10:1 warning Unexpected 'HACK' comment no-warning-comments␊
17-
11:1 warning Unexpected 'HERE BE DRAGONS' comment no-warning-comments␊
14+
8:1 warning Unexpected 'FIXME' comment: 'fixMe: Actually make this work' no-warning-comments␊
15+
9:1 warning Unexpected 'TODO' comment: 'todo: Add documentation' no-warning-comments␊
16+
10:1 warning Unexpected 'HACK' comment: 'Hack: Note that these work, regardless...' no-warning-comments␊
17+
11:1 warning Unexpected 'HERE BE DRAGONS' comment: 'Here be Dragons' no-warning-comments␊
1818
24:1 warning Remove the @description tag to leave a plain block description or add additional description text above the @description line jsdoc/require-description␊
1919
24:1 warning Missing JSDoc @param "params" declaration jsdoc/require-param␊
2020
24:1 warning JSDoc @returns declaration present but return expression not available in function jsdoc/require-returns-check␊
@@ -61,14 +61,9 @@ Generated by [AVA](https://ava.li).
6161
6:20 error Trailing comma json/trailing-comma␊
6262
8:3 error End of file expected json/undefined␊
6363
64-
example.test.html␊
65-
5:12 error describe.only not permitted no-only-tests/no-only-tests␊
66-
6:8 error it.only not permitted no-only-tests/no-only-tests␊
67-
10:8 warning it.skip not permitted no-skip-tests/no-skip-tests␊
68-
69-
/Users/Xacheiree/dev/familysearch/tree/eslint-config-tree/index.js␊
64+
/Users/clif/sandbox/frontier/common/eslint-config-tree/index.js␊
7065
52:0 warning Invalid JSDoc tag name "note" jsdoc/check-tag-names␊
7166
72-
52 problems (24 errors, 28 warnings)␊
67+
49 problems (22 errors, 27 warnings)␊
7368
4 errors and 3 warnings potentially fixable with the `--fix` option.␊
7469
`
6 Bytes
Binary file not shown.

index.js

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -148,8 +148,9 @@ module.exports = {
148148

149149
'bestpractices/no-eslint-disable': 'warn',
150150

151-
'no-only-tests/no-only-tests': 'error',
152-
'no-skip-tests/no-skip-tests': 'warn',
151+
// Duplicated by recent additions: jest/no-disabled-tests & jest/no-focused-tests
152+
// 'no-only-tests/no-only-tests': 'error',
153+
// 'no-skip-tests/no-skip-tests': 'warn',
153154

154155
'promise/always-return': 'warn',
155156
'promise/no-return-wrap': 'warn',

package.json

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "eslint-config-tree",
3-
"version": "3.0.0",
3+
"version": "4.0.0",
44
"description": "Shared Tree configuration that contains overrides and enhancements on top of the base frontier configuration.",
55
"main": "index.js",
66
"repository": {
@@ -32,8 +32,6 @@
3232
"eslint-plugin-import": "^2",
3333
"eslint-plugin-jsdoc": "^30",
3434
"eslint-plugin-json": "^2.1.2",
35-
"eslint-plugin-no-only-tests": "^2",
36-
"eslint-plugin-no-skip-tests": "^1",
3735
"eslint-plugin-node": "^11",
3836
"eslint-plugin-promise": "^4",
3937
"eslint-plugin-sonarjs": "^0.5",

0 commit comments

Comments
 (0)