Skip to content

Commit 9748d57

Browse files
authored
Upgrade to eslint v7 (#5)
Update to eslint v7. Update dependencies to latest releases. Add release information to README. Update test snapshots.
1 parent 38e4b0e commit 9748d57

File tree

4 files changed

+32
-16
lines changed

4 files changed

+32
-16
lines changed

README.md

Lines changed: 16 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -74,3 +74,19 @@ If there has been a change (say you added a new rule, or there is a new valid vi
7474
- Because this is a public repository, there are complications in adding references to private services and communications channels, so there is no Travis CI build and no Code Climate integration.
7575
- Coverage reporting ends up reporting on `lint-output.js`, instead of `index.js`, and so is also not used.
7676
- As noted in the `Testing/Updating` section, the only validation we do is to run linting against a file with a set of known failures. So we make sure to run `npm test` via a pre-push hook.
77+
78+
## Changelog:
79+
80+
<details>
81+
<summary>Version 3 - ESLint 7</summary>
82+
83+
- ESLint and dependencies updated to version 7.
84+
85+
</details>
86+
87+
<details>
88+
<summary>Version 2 - ESLint 6</summary>
89+
90+
- ESLint and dependencies based on version 6.
91+
92+
</details>

demo/test/snapshots/lint-output.js.md

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -9,11 +9,6 @@ Generated by [AVA](https://ava.li).
99
> Snapshot 1
1010
1111
`␊
12-
example.test.html␊
13-
5:12 error describe.only not permitted no-only-tests/no-only-tests␊
14-
6:8 error it.only not permitted no-only-tests/no-only-tests␊
15-
10:8 warning it.skip not permitted no-skip-tests/no-skip-tests␊
16-
1712
example.js␊
1813
6:0 warning Inline eslint-disable found bestpractices/no-eslint-disable␊
1914
8:1 warning Unexpected 'FIXME' comment no-warning-comments␊
@@ -42,8 +37,8 @@ Generated by [AVA](https://ava.li).
4237
43:5 warning 'variable' is never reassigned. Use 'const' instead prefer-const␊
4338
43:5 error 'variable' is assigned a value but never used no-unused-vars␊
4439
43:16 warning This conditional operation returns the same value whether the condition is "true" or "false" sonarjs/no-all-duplicated-branches␊
40+
43:16 error Unnecessary use of boolean literals in conditional expression no-unneeded-ternary␊
4541
43:17 error Unexpected constant condition no-constant-condition␊
46-
43:25 error Unnecessary use of boolean literals in conditional expression no-unneeded-ternary␊
4742
45:5 warning Correct one of the identical sub-expressions on both sides of operator "&&" sonarjs/no-identical-expressions␊
4843
45:16 warning Unexpected use of undefined no-undefined␊
4944
45:40 warning Unexpected use of undefined no-undefined␊
@@ -57,9 +52,6 @@ Generated by [AVA](https://ava.li).
5752
51:3 error '$' is not defined no-undef␊
5853
52:3 error Unexpected 'debugger' statement no-debugger␊
5954
60-
/Users/clif/sandbox/frontier/common/eslint-config-tree/index.js␊
61-
52:0 warning Invalid JSDoc tag name "note" jsdoc/check-tag-names␊
62-
6355
example.json␊
6456
4:6 error Property keys must be doublequoted json/undefined␊
6557
4:14 error Value expected json/value-expected␊
@@ -69,6 +61,14 @@ Generated by [AVA](https://ava.li).
6961
6:20 error Trailing comma json/trailing-comma␊
7062
8:3 error End of file expected json/undefined␊
7163
64+
example.test.html␊
65+
5:12 error describe.only not permitted no-only-tests/no-only-tests␊
66+
6:8 error it.only not permitted no-only-tests/no-only-tests␊
67+
10:8 warning it.skip not permitted no-skip-tests/no-skip-tests␊
68+
69+
/Users/Xacheiree/dev/familysearch/tree/eslint-config-tree/index.js␊
70+
52:0 warning Invalid JSDoc tag name "note" jsdoc/check-tag-names␊
71+
7272
✖ 52 problems (24 errors, 28 warnings)␊
7373
4 errors and 3 warnings potentially fixable with the `--fix` option.␊
7474
`
3 Bytes
Binary file not shown.

package.json

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "eslint-config-tree",
3-
"version": "2.1.1",
3+
"version": "3.0.0",
44
"description": "Shared Tree configuration that contains overrides and enhancements on top of the base frontier configuration.",
55
"main": "index.js",
66
"repository": {
@@ -23,18 +23,18 @@
2323
},
2424
"dependencies": {
2525
"babel-eslint": "^8",
26-
"eslint": "^6",
27-
"eslint-config-standard-react": "^7",
26+
"eslint": "^7",
2827
"eslint-config-standard": "^14",
28+
"eslint-config-standard-react": "^9",
2929
"eslint-plugin-bestpractices": "git+https://github.com/skye2k2/eslint-plugin-bestpractices.git",
3030
"eslint-plugin-deprecate": "^0.5",
31-
"eslint-plugin-html": "^6",
31+
"eslint-plugin-html": "^6.0.3",
3232
"eslint-plugin-import": "^2",
33-
"eslint-plugin-jsdoc": "^29",
34-
"eslint-plugin-json": "^2",
33+
"eslint-plugin-jsdoc": "^30",
34+
"eslint-plugin-json": "^2.1.2",
3535
"eslint-plugin-no-only-tests": "^2",
3636
"eslint-plugin-no-skip-tests": "^1",
37-
"eslint-plugin-node": "^9",
37+
"eslint-plugin-node": "^11",
3838
"eslint-plugin-promise": "^4",
3939
"eslint-plugin-sonarjs": "^0.5",
4040
"eslint-plugin-standard": "^4",

0 commit comments

Comments
 (0)