Read logoHref from snow res.locals for apple-touch-icon for PWAs #386
+95
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
redbugz
reviewed
May 5, 2025
redbugz
approved these changes
May 5, 2025
joeycozza
approved these changes
May 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the create-react-app part of the fix for https://icseng.atlassian.net/browse/FRONTIER-1197.
We are adding a value logoHref to Snow's res.locals for usage in
layout.ejsof frontier's react-scripts.This value is assigned from the app's
manifest.jsonif it exists, and the logo exists in it. Otherwise, the standard tree logo is assigned to it instead.Also, updated instructions for making changes in README-FRONTIER.