Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Attach ctx #50

Merged
merged 4 commits into from
Oct 15, 2024
Merged

Attach ctx #50

merged 4 commits into from
Oct 15, 2024

Conversation

dylanhitt
Copy link
Contributor

Took a pass at the utility function of handleCtx to limit some of the boiler plate. Let me know what you think.

@dylanhitt dylanhitt changed the title Attach ctx Draft: Attach ctx Oct 4, 2024
@dylanhitt dylanhitt changed the title Draft: Attach ctx Attach ctx Oct 4, 2024
@dylanhitt
Copy link
Contributor Author

@NSEcho Any thoughts on the above

@NSEcho
Copy link
Member

NSEcho commented Oct 11, 2024

Hey @dylanhitt, I didn't have much time to take a look at this, I will get to it over the weekend.

@NSEcho
Copy link
Member

NSEcho commented Oct 12, 2024

Hi @dylanhitt, could you please instead of ParamsCtx use ParamsWithContext convention throughout the code, otherwise looking okay

@dylanhitt
Copy link
Contributor Author

Sure I'll get to it tomorrow.

@dylanhitt
Copy link
Contributor Author

I think that should do it.

Thank you

@dylanhitt dylanhitt mentioned this pull request Oct 15, 2024
Closed
@NSEcho
Copy link
Member

NSEcho commented Oct 15, 2024

Thanks @dylanhitt

@NSEcho NSEcho merged commit 2b9405d into frida:main Oct 15, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dylanhitt @NSEcho