Update ureq example to version 3 of the ureq crate. #186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jfgoog
force-pushed
the
ureq-3
branch
2 times, most recently
from
1253d3a to
5d36eea
Compare
Byron
approved these changes
Feb 21, 2025
|
Thanks. Maybe the response conversion in examples/sparse_http_reqwest.rs can be cleaned up similarly? I basically copied it from there. |
|
Yes, please feel free to open another PR if there is something left to clean. Thanks a lot for your help. |
|
I took a look at the reqwest example. I think it's correct as-is, because reqwest uses its own response type, not the one from the http crate. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.