Bump rust-version to 1.81 and upgrade gix to v0.70
#183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tests passed locally. Maybe it's a spurious failure? |
Byron
requested changes
Jan 24, 2025
There was a problem hiding this comment.
Thanks a lot!
CI seems to be genuinely failing and that probably needs to be looked into. My feeling is that the test might have wrong expectations.
Please note that I also plan to follow up on the ODB issue and make fetches more resilient when there are long-running repositories.
| @@ -10,7 +10,7 @@ repository = "https://github.com/frewsxcv/rust-crates-index" | |||
| license = "Apache-2.0" | |||
| documentation = "https://docs.rs/crates-index/" | |||
| edition = "2021" | |||
| rust-version = "1.60" | |||
| rust-version = "1.81" | |||
There was a problem hiding this comment.
Can you help me understand this version bump?
I know gix shifted to 1.74 recently, but I could still compile this crate with this value being 1.60.
So I think it's fair to undo this line-change.
There was a problem hiding this comment.
Suggested change
| rust-version = "1.81" | |
| rust-version = "1.60" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.