Set commit #179
Merged
Set commit #179
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Byron
approved these changes
Dec 11, 2024
There was a problem hiding this comment.
Thanks for contributing, great work!
With an upgrade to the latest gix version the API became more convenient as well, and I could easily add error-handling, too.
I took a look at testing and added a minimal test, better than nothing, despite finding a 'use known hash and check that some crates will disappear' approach better, but it wasn't in the cards in terms of complexity when facing the 'rolling' history of the crates index.
I will create a new release shortly.
|
Unfortunately, I completely forgot to properly document the changes from your commits, but here we go: https://github.com/frewsxcv/rust-crates-index/releases/tag/v3.4.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A minimal API to solve my needs for #178.
Is this roughly what you had in mind? How would you like it tested? How would you like to see error handling dealt with?