git: Bail out if the url is sparse
#167
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I ended up in the accidental case where my URL is sparse, and believe
this could also happen if someone uses `replace-with` in their `.cargo/
config.toml`. When `GitIndex` is created, this ends up with a rather
useless error:
Refusing to initialize the non-empty directory as '/home/me/.cargo/registry/index/my-custom-registry'
Because it is probably not finding a `git` repository at that place,
without realizing that it's a sparse index cache.
To solve the `replace-with` case above, or make this crate more
generally usable, shouldn't there be (if there isn't already) a
high-level wrapper that automatically delegates to `SparseIndex` if
the URL starts with `sparse+`, and hide the `GitIndex`/`SparseIndex`
"internals"?
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I ended up in the accidental case where my URL is sparse, and believe this could also happen if someone uses
replace-within their.cargo/ config.toml. WhenGitIndexis created, this ends up with a rather useless error:Because it is probably not finding a
gitrepository at that place, without realizing that it's a sparse index cache.To solve the
replace-withcase above, or make this crate more generally usable, shouldn't there be (if there isn't already) a high-level wrapper that automatically delegates toSparseIndexif the URL starts withsparse+, and hide theGitIndex/SparseIndex"internals"?