Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update to gix v0.59 #162

Merged
merged 1 commit into from
Feb 25, 2024
Merged

Conversation

marcoieni
Copy link
Contributor

@marcoieni marcoieni commented Feb 25, 2024

Right now cargo check -F git is broken.

Error:

error[E0599]: the method `context` exists for fn item `fn(&mut &[u8]) -> Result<SignatureRef<'_>, ErrMode<_>> {decode::<'_, _>}`, but its trait bounds were not satisfied
   --> /Users/marcoieni/.cargo/registry/src/index.crates.io-6f17d22bba15001f/gix-ref-0.41.0/src/store/file/log/line.rs:142:46
    |
142 |                 gix_actor::signature::decode.context(StrContext::Expected("<name> <<email>> <timestamp>".into())),
    |                                              ^^^^^^^ method cannot be called due to unsatisfied trait bounds
    |
    = note: the following trait bounds were not satisfied:
            `<for<'a> fn(&'a mut &[u8]) -> Result<SignatureRef<'_>, winnow::error::ErrMode<_>> {gix_actor::signature::decode::<'_, _>} as FnOnce<(&mut _,)>>::Output = Result<_, ErrMode<_>>`
            which is required by `for<'a> fn(&'a mut &[u8]) -> Result<SignatureRef<'_>, winnow::error::ErrMode<_>> {gix_actor::signature::decode::<'_, _>}: winnow::Parser<_, _, _>`
            `<&for<'a> fn(&'a mut &[u8]) -> Result<SignatureRef<'_>, winnow::error::ErrMode<_>> {gix_actor::signature::decode::<'_, _>} as FnOnce<(&mut _,)>>::Output = Result<_, ErrMode<_>>`
            which is required by `&for<'a> fn(&'a mut &[u8]) -> Result<SignatureRef<'_>, winnow::error::ErrMode<_>> {gix_actor::signature::decode::<'_, _>}: winnow::Parser<_, _, _>`
            `<&mut for<'a> fn(&'a mut &[u8]) -> Result<SignatureRef<'_>, winnow::error::ErrMode<_>> {gix_actor::signature::decode::<'_, _>} as FnOnce<(&mut _,)>>::Output = Result<_, ErrMode<_>>`
            which is required by `&mut for<'a> fn(&'a mut &[u8]) -> Result<SignatureRef<'_>, winnow::error::ErrMode<_>> {gix_actor::signature::decode::<'_, _>}: winnow::Parser<_, _, _>`
    = help: items from traits can only be used if the trait is in scope
help: the following trait is implemented but not in scope; perhaps add a `use` for it:
    |
76  +     use winnow::parser::Parser;
    |

This PR seems to fix the issue.

If you accept this PR and merge it, can you release a new version, too, please?
My crate doesn't compile for this reason.

@marcoieni marcoieni marked this pull request as ready for review February 25, 2024 17:57
@Byron
Copy link
Collaborator

Byron commented Feb 25, 2024

This is interesting.

Is this something I did somehow? See also this issue that breaks similarly. It seems winnow is involved at least, but it's unclear if I could or should fix this or not.

It really seems that gix 0.58 is now broken after releasing gix 0.59. Maybe one of these newly released crates isn't a major version, but pulls in a more recent winnow patch release that can be breaking unless the code is prepared?

CC @epage .

@Byron Byron merged commit 110d4a8 into frewsxcv:master Feb 25, 2024
2 checks passed
@Byron
Copy link
Collaborator

Byron commented Feb 25, 2024

A new release was created: https://github.com/frewsxcv/rust-crates-index/releases/tag/v2.6.0 , I hope that helps.

@Byron
Copy link
Collaborator

Byron commented Feb 26, 2024

Please note that I yanked this release as gix 0.59 was yanked as well. There was simply no other way to fix this (somewhat quickly) :/.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants