locking behaviour improvements #146
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hen opening a git index. Previously, to allow concurrently opening and possibly updating a crates-index, a file-lock was used for synchronization. However, it was rather specific to what the test-suite needed while adding another failure mode for production code which could leave lock-files behind that then lock the crates-index forever for this library at least. Instead, appropriate locking will be used in tests only, while the documentation of all `open` methods of `GitIndex` was adjusted to inform about ways to protect concurrent accesses on application level.
Previously, discovery was used which may traverse the directory structure upwards to find the index. This may be error prone as the index location is supposed to be well-known. Now the index path provided must either be `.../index` or `.../index.git` to be opened successfully.
…pen without cloning. These methods are naturally read-only and thus have no issues in concurrent contexts, while not providing an option to not auto-clone a whole index.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #62 .
See what should be done about locking.
Improve docs