Turn into real ES Node module

[notlmn]

Closes #48

Shamelessly copied code over from https://github.com/fregante/github-url-detection because the state of ES module is a friggin mess right now.

Haven't tested this yet though, but it should work fine.

Sample npm pack:

npm notice 📦  [email protected]
npm notice === Tarball Contents === 
npm notice 1.1kB  license         
npm notice 26.7kB cjs/index.js    
npm notice 26.7kB esm/index.js    
npm notice 22B    esm/package.json
npm notice 1.6kB  package.json    
npm notice 9.1kB  readme.md       
npm notice 3.2kB  cjs/index.d.ts  
npm notice 3.2kB  esm/index.d.ts  
npm notice === Tarball Details === 
npm notice name:          webext-options-sync                     
npm notice version:       1.2.3                                   
npm notice filename:      webext-options-sync-1.2.3.tgz           
npm notice package size:  11.0 kB                                 
npm notice unpacked size: 71.6 kB                                 
npm notice shasum:        2c6cccbf80f18bd5cbc7ac2034d0d8dad3d128b1
npm notice integrity:     sha512-Qlw7e65RTyBUk[...]SA4sWujTi8vdg==
npm notice total files:   8                                       
npm notice 
webext-options-sync-1.2.3.tgz

[fregante]

Two issues:

• I actually had it before and dropped it (probably because my dependency was not a true ESM either) 35eb290
• Also webext-options-sync-per-domain would also have to be updated to support RGH

If this can be a true ESM, then it should ONLY be ESM following fregante/meta#1

[fregante]

I double-checked. 2 out of 3 dependencies are not true ESM so I can’t convert this one either.

The only way to convert would be to change the dependencies or vendor them (😬).

Following fregante/meta#1 also basically means that almost no changes in this PR are applicable.

[fregante]

Well I’m a bit silly. Rollup solves exactly that problem. So this PR only needs to drop the CJS bundle and just make it ESM by default

[fregante]

Can you also un-vendor this dependency? https://github.com/fregante/webext-options-sync/blob/master/vendor/lz-string.js

[fregante]

Base: 39kB

npm notice === Tarball Contents === 
npm notice 1.1kB  license     
npm notice 39.6kB index.js    
npm notice 1.6kB  package.json
npm notice 9.1kB  readme.md   
npm notice 3.2kB  index.d.ts  
npm notice === Tarball Details ===       
npm notice package size:  14.1 kB                                 
npm notice unpacked size: 54.5 kB

+ vendored lz-string: 34kB

npm notice === Tarball Contents === 
npm notice 1.1kB  license     
npm notice 34.4kB index.js    
npm notice 1.6kB  package.json
npm notice 9.1kB  readme.md   
npm notice 3.2kB  index.d.ts  
npm notice === Tarball Details ===        
npm notice package size:  13.3 kB                                 
npm notice unpacked size: 49.4 kB                                 

+ minifier: 28kB

npm notice === Tarball Contents === 
npm notice 1.1kB  license     
npm notice 28.0kB index.js    
npm notice 1.6kB  package.json
npm notice 9.1kB  readme.md   
npm notice 3.2kB  index.d.ts  
npm notice === Tarball Details ===         
npm notice package size:  10.8 kB                                 
npm notice unpacked size: 43.0 kB                

It's worth keeping both things as they are. Perhaps one day I'll be able to drop the serializer, but it's not easy... #28 (comment)

[fregante]

You can test it in your PR with:

npm install webext-options-sync@next

[fregante]

Note: WOS is already an ES Module, just not a Node ES Module. This PR is missing type:module, main:index.js

[fregante]

fregante/webext-options-sync-per-domain#1 also seems to be imported/tested correctly in RG under Node 14

[fregante]

Well, everything seems to work! Including #52

The tests still aren't compatible with Node 14, but that can be separate. Related: vadimdemedes/dom-chef#68 (but this package won't have the same problem)

webext-options-sync-per-domain would also need the same thing due to its mem dependency and can't be type:module until then (even if I tested it and it works in RG)

[fregante]

This will be released as a breaking release. If anyone can show just cause why this module cannot lawfully be published as breaking, let them speak now or forever hold their peace.

[notlmn]

If anyone can show just cause why this module cannot lawfully be published as breaking, let them speak now or forever hold their peace.

I blame Node ESM again!