Add unregister #2563
Merged
Add unregister #2563
+601
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emaste
reviewed
Dec 2, 2025
emaste
reviewed
Dec 2, 2025
docs/pkg-unregister.8
Outdated
| .Os | ||
| .Sh NAME | ||
| .Nm "pkg unregister" | ||
| .Nd deletes packages from the database |
Member
There was a problem hiding this comment.
"deletes package records from the database" maybe to make it very clear it's not touching the content
emaste
reviewed
Dec 2, 2025
docs/pkg-unregister.8
Outdated
| with unfulfilled dependencies, | ||
| .Nm | ||
| will add the packages with unfulfilled dependencies to the list of | ||
| packages to be deleted, unless forced to proceed without deleting any |
Member
There was a problem hiding this comment.
do we delete those or unregister them?
Member
|
CC @ifreund |
bapt
reviewed
Dec 2, 2025
libpkg/private/pkg.h
Outdated
| #define PKG_DELETE_UPGRADE (1 << 1) /* delete as a split upgrade */ | ||
| #define PKG_DELETE_NOSCRIPT (1 << 2) /* don't run delete scripts */ | ||
| #define PKG_DELETE_NOEXEC (1 << 3) /* don't run delete scripts which execute things*/ | ||
| #define PKG_DELETE_NOFILES (1 << 4) /* don't delete files */ |
bapt
reviewed
Dec 2, 2025
libpkg/pkg.h.in
Outdated
| PKG_FLAG_UPGRADE_VULNERABLE = (1U << 13), | ||
| PKG_FLAG_NOEXEC = (1U << 14) | ||
| PKG_FLAG_NOEXEC = (1U << 14), | ||
| PKG_FLAG_NODELETEFILES = (1U << 15) |
bapt
reviewed
Dec 2, 2025
src/main.c
Outdated
| { "stats", "Displays package database statistics", exec_stats, usage_stats}, | ||
| { "triggers", "Execute deferred triggers", exec_triggers, usage_triggers}, | ||
| { "unlock", "Unlocks a package, allowing modification or deletion", exec_unlock, usage_lock}, | ||
| { "unregister", "Deletes packages from the database", exec_unregister, usage_unregister}, |
Member
There was a problem hiding this comment.
Deletes packages entry from the database leaving the files on the filesystem ?
bapt
reviewed
Dec 2, 2025
Member
|
in general this looks good to me, mostly cosmetic and wording issues |
The goal of unregister is to remove the record from the database that a package is install but to no touch the files (or even run the scripts as we want to keep the generated data for example). This will allow people to migrate from a pkgbase to a non-pkgbase install. Sponsored by: Beckhoff Automation GmbH & Co. KG
Contributor
Author
It should be better now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The goal of unregister is to remove the record from the database that a package is install but to no touch the files (or even run the scripts as we want to keep the generated data for example). This will allow people to migrate from a pkgbase to a non-pkgbase install.
Sponsored by: Beckhoff Automation GmbH & Co. KG