Code

test: fix broken tests#260

Code

Merged

deepeshgarg007 merged 55 commits intofrappe:lending-uatfrappe/lending:lending-uatfrom the-bokya:test_maxxingthe-bokya/lending:test_maxxingCopy head branch name to clipboardFeb 7, 2025

+601-958

Commits

Commits on Jan 30, 2025

• fix: fix test_loan_totals

  the-bokya

  committed
  ebf1056

  Copy full SHA for ebf1056

• fix: add party checks for non- receivable/payable accounts

  the-bokya

  committed
  b313cf4

  Copy full SHA for b313cf4

• fix: fixed test_disbursal_check_without_shortfall

  the-bokya

  committed
  e9335a2

  Copy full SHA for e9335a2

• fix: add party checks for non- receivable/payable accounts -- again

  the-bokya

  committed
  053950d

  Copy full SHA for 053950d

• fix: add party checks for non- receivable/payable accounts -- once again in loan_demand

  the-bokya

  committed
  381e5dc

  Copy full SHA for 381e5dc

• fix: upsert for create_loan_accounts and fix create_repayment_entry

  the-bokya

  committed
  56c9dbe

  Copy full SHA for 56c9dbe

• fix: redo chart of accounts

  the-bokya

  committed
  b7c07bb

  Copy full SHA for b7c07bb

• fix: chart of accounts

  the-bokya

  committed
  ac0ecec

  Copy full SHA for ac0ecec

• WIP fix demand loans

  the-bokya

  committed
  5eefea8

  Copy full SHA for 5eefea8

• fix: check_sanctioned_amount_limit. repaid interest taken from loan repayment

  the-bokya

  committed
  22dc979

  Copy full SHA for 22dc979

• fix: test_principal_amount_paid was calculated for Actual/Actual and not for the default Actual/365

  the-bokya

  committed
  f7929f6

  Copy full SHA for f7929f6

• fix: temporary fix for test_pending_loan_amount_after_closure_request

  the-bokya

  committed
  30756f9

  Copy full SHA for 30756f9

• fix: fix test_partial_unaccrued_interest_payment

  the-bokya

  committed
  c66a078

  Copy full SHA for c66a078

• fix: fix test_npa_loan

  the-bokya

  committed
  0109dd4

  Copy full SHA for 0109dd4

• fix: fix test_npa_for_loc

  the-bokya

  committed
  bdebaf4

  Copy full SHA for bdebaf4

• fix: fix test_loan_write_off_entry - add interest_waiver_account as a field for create_loan_product and add catch for repay_from_salary

  the-bokya

  committed
  865ab1e

  Copy full SHA for 865ab1e

• fix: fix loan closures by subtracting excess_amount_paid. Fixes test_loan_closure

  the-bokya

  committed
  4636100

  Copy full SHA for 4636100

• fix: fix test_full_settlement

  the-bokya

  committed
  8411179

  Copy full SHA for 8411179

• fix: fix allocation of loan according to loan offset order

  the-bokya

  committed
  f587d19

  Copy full SHA for f587d19

• feat: fix add loan offset order to individual loan products with company being fallback

  the-bokya

  committed
  cf1ce09

  Copy full SHA for cf1ce09

• fix: add fixed date for test_loan_with_fixed_amount_per_period so that the values don't keep on changing based on nowdate()

  the-bokya

  committed
  73b9b52

  Copy full SHA for 73b9b52

• test: remove old tests

  the-bokya

  committed
  10809a1

  Copy full SHA for 10809a1

• test: remove old tests for loan interest accrual

  the-bokya

  committed
  4b1ded8

  Copy full SHA for 4b1ded8

• fix: change penalty_charges_rate's definition

  the-bokya

  committed
  967536d

  Copy full SHA for 967536d

• test: fix test_loan_with_repayment_periods

  the-bokya

  committed
  14a306a

  Copy full SHA for 14a306a

• test: fix test_penalty

  the-bokya

  committed
  271847a

  Copy full SHA for 271847a

• test: fix test_security_shortfall

  the-bokya

  committed
  4adcaa9

  Copy full SHA for 4adcaa9

• test: fix spelling mistake 🥲

  the-bokya

  committed
  f3046e2

  Copy full SHA for f3046e2

• test: upsert create_loan_product

  the-bokya

  committed
  1820dea

  Copy full SHA for 1820dea

• test: add additional interest accounts to create_loan_product

  the-bokya

  committed
  97f5362

  Copy full SHA for 97f5362

• test: fix test_loan_repayment_for_term_loans (nowdate() 🥲)

  the-bokya

  committed
  d027b3c

  Copy full SHA for d027b3c

• merge lending-uat into test_maxxing

  the-bokya

  committed
  b1b2ac8

  Copy full SHA for b1b2ac8

Commits on Feb 4, 2025

• fix: remove premature insert for loan_product

  the-bokya

  committed
  6a806be

  Copy full SHA for 6a806be

• fix: correct Disbursement Account name

  the-bokya

  committed
  38fb00d

  Copy full SHA for 38fb00d

• feat: get offset order from Loan Product and, if not present there, from Company

  the-bokya

  committed
  00df193

  Copy full SHA for 00df193

• test: fix test_loan_repayment_for_term_loans (nowdate() 🥲)

  the-bokya

  committed
  2e97668

  Copy full SHA for 2e97668

Commits on Feb 5, 2025

• chore: clean code

  the-bokya

  committed
  012a765

  Copy full SHA for 012a765

Commits on Feb 6, 2025

• test: fix all tests

  the-bokya

  committed
  35c3be3

  Copy full SHA for 35c3be3

• Merge branch 'lending-uat' of https://github.com/frappe/lending into test_maxxing

  deepeshgarg007

  committed
  0f2a688

  Copy full SHA for 0f2a688

• fix: just testing out changes to install.sh

  the-bokya

  committed
  2053c6b

  Copy full SHA for 2053c6b

• fix: see if bench get-app works

  the-bokya

  committed
  881dc7f

  Copy full SHA for 881dc7f

• fix: random linter problems

  the-bokya

  committed
  8a15229

  Copy full SHA for 8a15229

• fix: create_loan_product

  the-bokya

  committed
  ef9571c

  Copy full SHA for ef9571c

• fix: get loan_accrual_frequency if not present in calculate_accrual_amount_for_loans

  the-bokya

  committed
  56f7917

  Copy full SHA for 56f7917

• fix: initialise total_payable_amount

  the-bokya

  committed
  b1180d8

  Copy full SHA for b1180d8

• test: add precision check for test_loan_repayment_for_term_loan

  the-bokya

  committed
  247519f

  Copy full SHA for 247519f

• test: all tests pass

  the-bokya

  committed
  6a0ce30

  Copy full SHA for 6a0ce30

Commits on Feb 7, 2025

• fix: party validation catches fixed for waiver entries

  the-bokya

  committed
  7c50643

  Copy full SHA for 7c50643

• fix: undo changes in no_of_days

  the-bokya

  committed
  b586657

  Copy full SHA for b586657

• test: set a global defaults for testing (default_company, default_currency, country)

  the-bokya

  committed
  b2aad7b

  Copy full SHA for b2aad7b

• test: semgrep fixes (partial)

  the-bokya

  committed
  fb18d9b

  Copy full SHA for fb18d9b

• chore: temporarily escape semgreps

  the-bokya

  committed
  260ccb9

  Copy full SHA for 260ccb9

• chore: remove codecov action

  the-bokya

  committed
  8341cda

  Copy full SHA for 8341cda

• fix: remove unnecessary process_loan_interest_accrual

  the-bokya

  committed
  5249015

  Copy full SHA for 5249015

• fix: remove unnecessary catches for ERPNext party/party_type validation in Loan Demand

  the-bokya

  committed
  f86b048

  Copy full SHA for f86b048