Skip to content

fix: broken link#4353

Merged
asmitahase merged 1 commit intofrappe:developfrom
asmitahase:fix-links
Apr 9, 2026
Merged

fix: broken link#4353
asmitahase merged 1 commit intofrappe:developfrom
asmitahase:fix-links

Conversation

@asmitahase
Copy link
Copy Markdown
Member

@asmitahase asmitahase commented Apr 9, 2026

Summary by CodeRabbit

  • Bug Fixes
    • Updated navigation link destination in the main navigation menu.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Apr 9, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: cbcc59af-b365-40f0-a299-432277aac5d5

📥 Commits

Reviewing files that changed from the base of the PR and between a4b766b and af1e345.

📒 Files selected for processing (1)
  • roster/src/components/NavBar.vue

Walkthrough

The change updates a navigation link in the NavBar component. Specifically, the href attribute of the "Frappe HR" navigation link was modified from /app/hr to /desk/people. This is a routing change that alters the destination when users interact with that navbar entry. No other structural or functional modifications were made to the component.

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'fix: broken link' directly addresses the main change—fixing a broken navigation link in NavBar.vue from /app/hr to /desk/people.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@asmitahase asmitahase merged commit daa1b99 into frappe:develop Apr 9, 2026
12 checks passed
asmitahase added a commit that referenced this pull request Apr 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant