Skip to content

fix: prevent arithmetic error when fix_plan.md has no matching checkboxes #260

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
fengwuqingchen wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: prevent arithmetic error when fix_plan.md has no matching checkboxes #260

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 11 additions & 2 deletions ralph_loop.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -711,8 +711,17 @@ should_exit_gracefully() {
# Fix #144: Only match valid markdown checkboxes, not date entries like [2026-01-29]
# Valid patterns: "- [ ]" (uncompleted) and "- [x]" or "- [X]" (completed)
if [[ -f "$RALPH_DIR/fix_plan.md" ]]; then
local uncompleted_items=$(grep -cE "^[[:space:]]*- \[ \]" "$RALPH_DIR/fix_plan.md" 2>/dev/null || echo "0")
local completed_items=$(grep -cE "^[[:space:]]*- \[[xX]\]" "$RALPH_DIR/fix_plan.md" 2>/dev/null || echo "0")
# BSD grep (macOS) prints "0" to stdout AND exits 1 when no matches,
# so the previous `grep -c ... || echo "0"` fallback appended a second
# "0", producing a multi-line "0\n0" value that broke the $((...))
# arithmetic with: "syntax error in expression (error token is "0")".
# Pipe through `head -n1` to mask the non-zero exit and keep one line.
local uncompleted_items
uncompleted_items=$(grep -cE "^[[:space:]]*- \[ \]" "$RALPH_DIR/fix_plan.md" 2>/dev/null | head -n1)
local completed_items
completed_items=$(grep -cE "^[[:space:]]*- \[[xX]\]" "$RALPH_DIR/fix_plan.md" 2>/dev/null | head -n1)
uncompleted_items=${uncompleted_items:-0}
completed_items=${completed_items:-0}
local total_items=$((uncompleted_items + completed_items))

if [[ $total_items -gt 0 ]] && [[ $completed_items -eq $total_items ]]; then
Expand Down