Skip to content

fix(pr_v2): close httpx client in all 5 remaining PR endpoints #582

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
frankbria merged 1 commit into from
Apr 14, 2026
Merged

fix(pr_v2): close httpx client in all 5 remaining PR endpoints #582

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 15 additions & 5 deletions codeframe/ui/routers/pr_v2.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -259,8 +259,8 @@ async def list_pull_requests(
Returns:
List of pull requests
"""
client = _get_github_client()
try:
client = _get_github_client()
prs = await client.list_pull_requests(state=state)

return PRListResponse(
Expand All @@ -281,6 +281,8 @@ async def list_pull_requests(
status_code=500,
detail=api_error("Failed to list PRs", ErrorCodes.EXECUTION_FAILED, str(e)),
)
finally:
await client.close()


@router.get("/{pr_number}", response_model=PRResponse)
Expand All @@ -299,8 +301,8 @@ async def get_pull_request(
Returns:
PR details
"""
client = _get_github_client()
try:
client = _get_github_client()
pr = await client.get_pull_request(pr_number)

return _pr_to_response(pr)
Expand All @@ -323,6 +325,8 @@ async def get_pull_request(
status_code=500,
detail=api_error("Failed to get PR", ErrorCodes.EXECUTION_FAILED, str(e)),
)
finally:
await client.close()


@router.post("", response_model=PRResponse, status_code=201)
Expand All @@ -342,8 +346,8 @@ async def create_pull_request(
Returns:
Created PR details
"""
client = _get_github_client()
try:
client = _get_github_client()
pr = await client.create_pull_request(
branch=body.branch,
title=body.title,
Expand All @@ -366,6 +370,8 @@ async def create_pull_request(
status_code=500,
detail=api_error("Failed to create PR", ErrorCodes.EXECUTION_FAILED, str(e)),
)
finally:
await client.close()


@router.post("/{pr_number}/merge", response_model=MergeResponse)
Expand All @@ -389,8 +395,8 @@ async def merge_pull_request(
"""
method = body.method if body else "squash"

client = _get_github_client()
try:
client = _get_github_client()
result = await client.merge_pull_request(pr_number, method=method)

return MergeResponse(
Expand Down Expand Up @@ -422,6 +428,8 @@ async def merge_pull_request(
status_code=500,
detail=api_error("Failed to merge PR", ErrorCodes.EXECUTION_FAILED, str(e)),
)
finally:
await client.close()


@router.post("/{pr_number}/close")
Expand All @@ -440,8 +448,8 @@ async def close_pull_request(
Returns:
Close confirmation
"""
client = _get_github_client()
try:
client = _get_github_client()
closed = await client.close_pull_request(pr_number)

return {
Expand All @@ -467,3 +475,5 @@ async def close_pull_request(
status_code=500,
detail=api_error("Failed to close PR", ErrorCodes.EXECUTION_FAILED, str(e)),
)
finally:
await client.close()
Loading