Skip to content

Guus/param var conv #1146

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 31 commits into
base: devel
Choose a base branch
from
Open

Guus/param var conv #1146

wants to merge 31 commits into from

Conversation

guusw
Copy link
Member

@guusw guusw commented May 27, 2025

Cleanup and fix various warnings (update spdlog due to some)

@guusw guusw force-pushed the guus/param-var-conv branch 2 times, most recently from 241548d to 68e84b6 Compare May 27, 2025 11:43
@guusw guusw force-pushed the guus/param-var-conv branch from cec3593 to 4623382 Compare May 30, 2025 12:07
Copy link

codecov bot commented May 30, 2025

Codecov Report

Attention: Patch coverage is 78.02817% with 78 lines in your changes missing coverage. Please review.

Project coverage is 77.66%. Comparing base (825f79b) to head (5915a5f).
Report is 15 commits behind head on devel.

Files with missing lines Patch % Lines
shards/modules/core/core.cpp 79.06% 27 Missing ⚠️
shards/core/ops_internal.hpp 47.05% 9 Missing ⚠️
shards/core/check_utils.hpp 61.53% 5 Missing ⚠️
shards/core/coro_annotations.inl 90.24% 4 Missing ⚠️
shards/core/foundation.hpp 60.00% 4 Missing ⚠️
shards/core/exception.hpp 0.00% 3 Missing ⚠️
shards/core/runtime.cpp 40.00% 3 Missing ⚠️
shards/gfx/fmt.hpp 25.00% 3 Missing ⚠️
shards/modules/core/core.hpp 91.89% 3 Missing ⚠️
shards/gfx/error_utils.hpp 0.00% 2 Missing ⚠️
... and 11 more
Additional details and impacted files
@@            Coverage Diff             @@
##            devel    #1146      +/-   ##
==========================================
- Coverage   77.77%   77.66%   -0.11%     
==========================================
  Files         379      383       +4     
  Lines       59190    59048     -142     
==========================================
- Hits        46035    45861     -174     
- Misses      13155    13187      +32     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant