Skip to content

Correctly set tlast in RDMA re-transmission multiplexer#203

Merged
maximilianheer merged 1 commit intofpgasystems:masterfrom
bo3z:bugfix/rdma-retrans
Mar 5, 2026
Merged

Correctly set tlast in RDMA re-transmission multiplexer#203
maximilianheer merged 1 commit intofpgasystems:masterfrom
bo3z:bugfix/rdma-retrans

Conversation

@bo3z
Copy link
Copy Markdown
Collaborator

@bo3z bo3z commented Mar 5, 2026

Description

Fixes the incorrectly set tlast signal in RDMA retrans MUX by considering the current command, not incoming command. This bug could lead to erroneous transmissions (as reported in PR #191) as well as critical failures in ACCL.

Type of change

  • Bug fix
  • New feature
  • Documentation update
  • A new research paper code implementation
  • Other

Tests & Results

Confirmed by running Example 9 dozens of times, with 100 runs and 128 throughput repetitions. Close to 200M packets exchanged with no drops.

Checklist

  • I have commented my code and made corresponding changes to the documentation.
  • I have added tests/results that prove my fix is effective or that my feature works.
  • My changes generate no new warnings or errors & all tests successfully pass.

@bo3z bo3z requested a review from maximilianheer March 5, 2026 16:02
@bo3z bo3z added the bugfix Fix for a bug label Mar 5, 2026
@bo3z bo3z added this to the 0.3.0 milestone Mar 5, 2026
Copy link
Copy Markdown
Member

@maximilianheer maximilianheer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed: Works!

@maximilianheer maximilianheer merged commit aa567a2 into fpgasystems:master Mar 5, 2026
1 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bugfix Fix for a bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants