Skip to content

Allow installing the Coyote software library (and simulation)#185

Merged
bo3z merged 18 commits intofpgasystems:masterfrom
lucat1:master
Jan 28, 2026
Merged

Allow installing the Coyote software library (and simulation)#185
bo3z merged 18 commits intofpgasystems:masterfrom
lucat1:master

Conversation

@lucat1
Copy link
Copy Markdown
Contributor

@lucat1 lucat1 commented Jan 22, 2026

Description

This PR changes the CMake setup for the software side of coyote, in particular:

  1. Both the normal software library and the simulation software library can be installed system-wide.
  2. To account for this, the simulation now reads the build folder path from environment variable, instead of having it hardcoded in the compiled library objects.
  3. Examples have been changed to use add_subdirectory instead of FindCoyoteSW.
  4. FindCoyoteSW has been deprecated in favor of the standard find_package or add_subdirectory. A deprecation warning has been put in place, so legacy code using FindCoyoteSW won't break.
  5. #includes of coyote have been changed from #include "cThread.hpp>" to include <coyote/cThread.hpp> in the software library headers to avoid any conflicts breakage when headers are installed system wide.

Type of change

  • Bug fix
  • New feature
  • Documentation update
  • A new research paper code implementation
  • Other

Tests & Results

The software and simulation libraries have been compiled and installed. Files are placed in the install folder as expected. All examples have also been compiled successfully.

Checklist

  • I have commented my code and made corresponding changes to the documentation.
  • I have added tests/results that prove my fix is effective or that my feature works.
  • My changes generate no new warnings or errors & all tests successfully pass.

@lucat1 lucat1 force-pushed the master branch 2 times, most recently from 39ce84c to 7441093 Compare January 22, 2026 10:27
Copy link
Copy Markdown
Collaborator

@bo3z bo3z left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly looks good. Most of these are minor questions for my understating.

One thing I am unclear on is: how do I compile for simulation? In the past, we used to pass the flag EN_SIM. How does it now work, in both cases (both as a system-wide installation as well as a sub-directory)

@bo3z bo3z added this to the 0.3.0 milestone Jan 22, 2026
bo3z and others added 2 commits January 28, 2026 11:10
Fix RDMA include issue with new Coyote libs & update simulation workf…
Copy link
Copy Markdown
Collaborator

@bo3z bo3z left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bo3z bo3z merged commit 4459deb into fpgasystems:master Jan 28, 2026
@lucat1 lucat1 mentioned this pull request Feb 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants