Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: refine device build #745

Merged
merged 3 commits into from
Sep 28, 2024
Merged

refactor: refine device build #745

merged 3 commits into from
Sep 28, 2024

Conversation

MrCroxx
Copy link
Collaborator

@MrCroxx MrCroxx commented Sep 27, 2024

What's changed and what's your intention?

Please explain IN DETAIL what the changes are in this PR and why they are needed. :D

Make sure can use XxxDeviceOptions directly with with_device_options(). The old builder looks so wired.

Checklist

  • I have written the necessary rustdoc comments
  • I have added the necessary unit tests and integration tests
  • I have passed make all (or make fast instead if the old tests are not modified) in my local environment.

Related issues or PRs (optional)

#327

@MrCroxx MrCroxx added this to the v0.12 milestone Sep 27, 2024
@MrCroxx MrCroxx self-assigned this Sep 27, 2024
Copy link

codecov bot commented Sep 27, 2024

Codecov Report

Attention: Patch coverage is 87.67123% with 9 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
foyer-bench/src/main.rs 50.00% 3 Missing ⚠️
foyer-storage/src/device/mod.rs 57.14% 3 Missing ⚠️
foyer-storage/src/store.rs 81.81% 2 Missing ⚠️
foyer-storage/src/device/monitor.rs 80.00% 1 Missing ⚠️
Files with missing lines Coverage Δ
foyer-storage/src/device/direct_file.rs 85.16% <100.00%> (+0.24%) ⬆️
foyer-storage/src/device/direct_fs.rs 88.06% <100.00%> (+0.20%) ⬆️
foyer-storage/src/large/generic.rs 89.83% <100.00%> (-0.06%) ⬇️
foyer-storage/src/large/scanner.rs 75.42% <100.00%> (-0.28%) ⬇️
foyer-storage/src/large/tombstone.rs 96.55% <100.00%> (ø)
foyer-storage/src/small/generic.rs 74.61% <100.00%> (-0.27%) ⬇️
foyer/src/hybrid/builder.rs 95.15% <100.00%> (ø)
foyer/src/hybrid/cache.rs 82.66% <100.00%> (-0.11%) ⬇️
foyer-storage/src/device/monitor.rs 81.00% <80.00%> (+2.35%) ⬆️
foyer-storage/src/store.rs 86.81% <81.81%> (ø)
... and 2 more

... and 1 file with indirect coverage changes

@MrCroxx MrCroxx merged commit 7b2b9ce into main Sep 28, 2024
22 checks passed
@MrCroxx MrCroxx deleted the xx/opts branch September 28, 2024 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

1 participant