Skip to content

fix: set lobby to null on disconnect and prevent selecting lobby out of bounds #92

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jonandrewdavis wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: set lobby to null on disconnect and prevent selecting lobby out of bounds #92

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions nohub.gd/browser.tscn
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -145,6 +145,7 @@ func _disconnect() -> void:
_connection = null
_client = null

set_selected_lobby(null)
lobby_list.clear()
_lobbies_in_list.clear()
address_label.text = \"\"
Expand Down Expand Up @@ -190,6 +191,10 @@ func _select_lobby(clicked_idx: int, _selected: bool = true) -> void:
# User clicked header row, do nothing
return

if _lobbies_in_list.size() - 1 < row_idx:
# Row is not present
return

var lobby := _lobbies_in_list[row_idx]
set_selected_lobby(lobby)

Expand Down
Loading