Refactor unix cronjob plugin #1009
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Schamper
requested changes
Jan 30, 2025
Co-authored-by: Erik Schamper <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1009 +/- ##
==========================================
+ Coverage 77.77% 77.96% +0.18%
==========================================
Files 327 327
Lines 28659 28658 -1
==========================================
+ Hits 22290 22342 +52
+ Misses 6369 6316 -53
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Horofic
reviewed
Jan 30, 2025
| for file in self.crontabs: | ||
| for line in file.open("rt"): | ||
| line = line.strip() | ||
| if line.startswith("#") or not len(line): |
There was a problem hiding this comment.
Suggested change
| if line.startswith("#") or not len(line): | |
| if line.startswith("#") or not line: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors the unix cronjob plugin and adds tests.