Fix qcow2 support for absolute backing_file paths #65
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
_open_backing_file assumed that the backing_file path
was always a filename relative to the snapshot path.
Using .with_name() to concat the whole path broke the use
case for absolute path for the backing_file causing
ValueError("Invalid name ...").
This change updates the logic to detect whether auto_backing_file is an
absolute path. If so, it is used directly; otherwise we fall back to
constructing the path relative to the snapshot location.
This will support the following use-cases:
backing file: /home/user/workdir/ubuntu-22.04.qcow2
backing file: ubuntu-22.04.qcow2
backing file: ./ubuntu-22.04-packer.qcow2
backing file: ../../ubuntu-22.04-packer.qcow2
Fixes: fox-it#64
Signed-off-by: Andreia Ocanoaia <[email protected]>
Schamper
previously approved these changes
Oct 1, 2025
Member
Schamper
left a comment
Schamper
left a comment
There was a problem hiding this comment.
Thanks @andreia-oca, I made a small change that should achieve the same. I also added some unit tests.
The reason I didn't use Path is because in dissect.target we use a custom subclass of it. Using joinpath ensures we stay within that subclass.
Could you maybe verify that it still works as expected on your end?
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #65 +/- ##
==========================================
+ Coverage 77.66% 77.84% +0.18%
==========================================
Files 26 26
Lines 2207 2207
==========================================
+ Hits 1714 1718 +4
+ Misses 493 489 -4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
_open_backing_file assumed that the backing_file path was always a filename relative to the snapshot path. Using .with_name() to concat the whole path broke the use case for absolute path for the backing_file causing ValueError("Invalid name ...").
This change updates the logic to detect whether auto_backing_file is an absolute path. If so, it is used directly; otherwise we fall back to constructing the path relative to the snapshot location.
This will support the following use-cases:
backing file: /home/user/workdir/ubuntu-22.04.qcow2 backing file: ubuntu-22.04.qcow2
backing file: ./ubuntu-22.04-packer.qcow2
backing file: ../../ubuntu-22.04-packer.qcow2
Fixes: #64