Skip to content

Add sncast get tx#4217

Open
DelevoXDG wants to merge 13 commits intomasterfrom
zdobnikau/sncast-transaction
Open

Add sncast get tx#4217
DelevoXDG wants to merge 13 commits intomasterfrom
zdobnikau/sncast-transaction

Conversation

@DelevoXDG
Copy link
Contributor

@DelevoXDG DelevoXDG commented Mar 17, 2026

Towards #4144

Stack

Introduced changes

Checklist

  • Linked relevant issue
  • Updated relevant documentation
  • Added relevant tests
  • Performed self-review of the code
  • Added changes to CHANGELOG.md

@DelevoXDG
Copy link
Contributor Author

DelevoXDG commented Mar 17, 2026

Some transactions are tricky to test, but you can check these locally:

Deploy

sncast_build get tx 0x1d08158d139345d562276f0a085d9764e618eba788bed99a238903595b17022 --network mainnet

L1 handler

sncast_build get tx 0x294f5246c1174c240e225c5eaf5d184f8868cb745e28da47dfb80512afbac1c --network mainnet

Since we're using starknet-rs logic, I'm not sure there's a point in setting up some workarounds e.g. mock responses to test every case for sncast 🤔

@DelevoXDG DelevoXDG force-pushed the zdobnikau/sncast-transaction branch from a823ad6 to 16f4c88 Compare March 17, 2026 12:06
@DelevoXDG DelevoXDG changed the base branch from master to zdobnikau/fix-sncast-get-docs March 17, 2026 12:07
@DelevoXDG DelevoXDG force-pushed the zdobnikau/sncast-transaction branch from 16f4c88 to a2648b7 Compare March 17, 2026 13:28
@DelevoXDG DelevoXDG marked this pull request as ready for review March 17, 2026 15:04
@DelevoXDG DelevoXDG requested a review from a team as a code owner March 17, 2026 15:04
@DelevoXDG DelevoXDG requested review from MKowalski8 and franciszekjob and removed request for a team March 17, 2026 15:04
github-merge-queue bot pushed a commit that referenced this pull request Mar 17, 2026
I thought I moved these sections (#4215), but apparently I accidentally
just removed these 😬


## Stack
- #4215 
- #4210
- #4218 
- #4217 
- #4219

## Introduced changes

<!-- A brief description of the changes -->

- add `sncast get balance, tx-status` docs back 

## Checklist

<!-- Make sure all of these are complete -->

- [ ] Linked relevant issue
- [x] Updated relevant documentation
- [ ] Added relevant tests
- [ ] Performed self-review of the code
- [ ] Added changes to `CHANGELOG.md`
Base automatically changed from zdobnikau/fix-sncast-get-docs to master March 17, 2026 15:12
@DelevoXDG DelevoXDG force-pushed the zdobnikau/sncast-transaction branch from f7f10c9 to 9dd68d7 Compare March 18, 2026 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant