Remove apply_test_resource_bounds_flags#4212
Conversation
| "--constructor-calldata", | ||
| "0x1", | ||
| "0x1", | ||
| "0x0", |
There was a problem hiding this comment.
note: Map contract does not have any constructor params, so passing them was incorrect. (similarly below)
| }, | ||
| indoc! {r#" | ||
| Command: deploy | ||
| Error: Transaction execution error = TransactionExecutionErrorData { transaction_index: 0, execution_error: Message("Account transaction nonce is invalid.") } |
There was a problem hiding this comment.
Should we update From<StarknetError> for SNCastStarknetError for more human-readable error message?
There was a problem hiding this comment.
Hmm, theoretically we can but I guess that there are other similar cases in which we could match the data of tx execution error and map it to a different one. Can apply this, but ideally in separate PR. Is that ok @DelevoXDG ?
ddoktorski
left a comment
ddoktorski
left a comment
There was a problem hiding this comment.
Do we have any tests that use fee arguments after this change?
Yes, e.g. this one. And similarly for deploy, invoke |
3 participants
Closes #
Introduced changes
When bumping RPC some time ago,
apply_test_resource_boundswas introduced. Because of issues with fee estimation by devnet, we used hard-coded resource bounds. It's not relevant anymore.Checklist
CHANGELOG.md