Skip to content

Simplify legacy blob gas fallback in BlockEnv conversion #12418

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Simplify legacy blob gas fallback in BlockEnv conversion #12418

wants to merge 1 commit into from
+4 −3

Conversation

@DotFunGuy
Copy link

@DotFunGuy DotFunGuy commented Nov 2, 2025

  • replace the redundant or_else closure with Option::or
  • keep the default blob gas values identical while making the code clearer

@onbjerg onbjerg closed this Nov 3, 2025
@github-project-automation github-project-automation bot moved this to Done in Foundry Nov 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@DaniPopes DaniPopes Awaiting requested review from DaniPopes DaniPopes is a code owner

@mattsse mattsse Awaiting requested review from mattsse mattsse is a code owner

@grandizzy grandizzy Awaiting requested review from grandizzy grandizzy is a code owner

@zerosnacks zerosnacks Awaiting requested review from zerosnacks zerosnacks is a code owner

@onbjerg onbjerg Awaiting requested review from onbjerg onbjerg is a code owner

@0xrusowsky 0xrusowsky Awaiting requested review from 0xrusowsky 0xrusowsky is a code owner

Assignees

No one assigned

Labels

None yet

Projects

Foundry
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@DotFunGuy @onbjerg