fix(fmt): correct peek_comment_between to scan comments within range #12218
+46
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The function used take_while with a range predicate starting from the first comment in the file. This stops iteration as soon as a comment before pos_lo is encountered, causing the function to almost always return None when earlier comments exist.
Lists relying on this check (e.g., commasep’s has_comments computation) could mis-detect “no comments between”, affecting line breaking and spacing decisions.
Solution
Replace the logic with skip_while(c.pos() <= pos_lo) + take_while(c.pos() < pos_hi) and find the first non-blank. This matches the intended semantics and aligns with has_comment_between’s filtering approach.
PR Checklist