feat: add some clippy lint - #10479
Merged
mattsse merged 3 commits intoJun 5, 2025
Merged
Conversation
taikoonwang
requested review from
DaniPopes,
grandizzy,
klkvr,
mattsse,
yash-atreya and
zerosnacks
as code owners
May 9, 2025 07:01
mattsse
previously approved these changes
May 9, 2025
mattsse
left a comment
mattsse
left a comment
Member
There was a problem hiding this comment.
these lgtm, pending @DaniPopes @grandizzy
zerosnacks
reviewed
May 9, 2025
zerosnacks
reviewed
May 9, 2025
taikoonwang
force-pushed
the
lint/cloned_instead_of_copied
branch
from
May 13, 2025 09:17
5919830 to
bd4445d
Compare
Contributor
Author
|
@grandizzy fixed some conflicts, plz review again |
taikoonwang
commented
May 13, 2025
| let mut log_index = 0; | ||
| let mut gas_used = 0; | ||
| let mut transactions = Vec::with_capacity(calls.len()); | ||
| let mut receipts = Vec::new(); |
Contributor
Author
There was a problem hiding this comment.
warning: collection is never read
--> crates/anvil/src/eth/backend/mem/mod.rs:1537:17
|
1537 | let mut receipts = Vec::new();
Collaborator
Contributor
There was a problem hiding this comment.
also wondering this, the rest of the changes LGTM
grandizzy
approved these changes
Jun 5, 2025
grandizzy
left a comment
grandizzy
left a comment
Collaborator
There was a problem hiding this comment.
this lgtm, thank you, pending @mattsse @zerosnacks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
closes #10149
torward: #10150
The above PR involved too many linting rules, so this time I want to split it into smaller PRs, similar to reth. Each PR will contain around 5 linting rules to make reviewing easier.
Solution
PR Checklist