-
Notifications
You must be signed in to change notification settings - Fork 2k
feat(forge): implement vm.signTypedData cheatcode #10330
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
Haxry
wants to merge
21
commits into
foundry-rs:master
Choose a base branch
from
Haxry:eip712
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
Show all changes
21 commits
Select commit
Hold shift + click to select a range
fcae5fd
add cheatcode
Haxry ed08628
configure
Haxry 78f2cb5
add documentation
Haxry 8d4e4ca
formatted
Haxry f2683ae
Merge branch 'foundry-rs:master' into eip712
Haxry 6bc61be
Merge branch 'foundry-rs:master' into eip712
Haxry 0b3ae86
shifted to alloy
Haxry ce1bb9d
add pvt key to traces
Haxry 724d761
configure
Haxry fc293a3
minor change
Haxry 432a20a
Merge remote-tracking branch 'upstream/master' into vm-sign-typed
grandizzy 7439c2b
Cargo cheats
grandizzy a42bb38
Alloy workspace
grandizzy cb7bee7
Merge branch 'foundry-rs:master' into eip712
Haxry 9e8623c
fix: merge conflicts
0xrusowsky 7148b94
impl cheat eip712HashTypedData + unit tests
0xrusowsky 1d77dc2
fix: redact pk
0xrusowsky 53f0963
wrap ffi call to cast
0xrusowsky e35a1d5
Merge branch 'master' into eip712
0xrusowsky b54f83b
revert cast call due to FFI risk
0xrusowsky 3c49f19
Merge branch 'eip712' of github.com:Haxry/foundry into chore/finish-e…
0xrusowsky File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -65,3 +65,4 @@ tracing.workspace = true | |
walkdir.workspace = true | ||
proptest.workspace = true | ||
serde.workspace = true | ||
|
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@grandizzy i noticed that
signDelegation
andsignAndAttachDelegation
are under theScripting
group, howeversignTypedData
is underCrypto
.does it matter? should we change its group perhaps?