Skip to content

feat: support getAccount mode #48

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

feat: support getAccount mode #48

wants to merge 7 commits into from

Conversation

Rimeeeeee
Copy link

fixes #47

mattsse
mattsse requested changes May 10, 2025
View reviewed changes
Copy link
Member

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great start

@Rimeeeeee Rimeeeeee requested a review from mattsse May 11, 2025 05:51
@yash-atreya yash-atreya mentioned this pull request May 14, 2025
Open
mattsse
mattsse requested changes May 21, 2025
View reviewed changes
Copy link
Member

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cool, the only thing missing is some simplifications to make this super nice to read

@Rimeeeeee Rimeeeeee requested a review from mattsse May 23, 2025 14:38
@Rimeeeeee Rimeeeeee mentioned this pull request May 28, 2025
Draft
mattsse
mattsse requested changes Jun 4, 2025
View reviewed changes
Copy link
Member

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

almost forgot about this,

last style nits

@Rimeeeeee Rimeeeeee requested a review from mattsse June 5, 2025 08:56
mattsse
mattsse requested changes Jun 10, 2025
View reviewed changes
Copy link
Member

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

okay, thanks for sticking around, and sorry for the delay...

last suggestion, hope it makes sense, maybe we need to use pin_mut! here for the triple, but i think we can just await it if the acc_info_fut succeeds first

@Rimeeeeee Rimeeeeee requested a review from mattsse June 11, 2025 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DaniPopes DaniPopes Awaiting requested review from DaniPopes DaniPopes is a code owner

@klkvr klkvr Awaiting requested review from klkvr klkvr is a code owner

@mattsse mattsse Awaiting requested review from mattsse mattsse is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support getAccount mode
2 participants
@Rimeeeeee @mattsse