bsp: tegra: systemd-boot: double dtb buffer size #1590
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is probably due to fact systemd-boot does not allocate any extra space for the device tree. Without the modification, because there is not any extra space, the UEFI will fail applying the overlay changes from its .dtbo files Fixes: | EFI stub: ERROR: Invalid header detected on UEFI supplied FDT, ignoring ... | EFI stub: Generating empty DTB References: anduril/jetpack-nixos#111 Signed-off-by: Jose Quaresma <[email protected]>
|
Can we test on the lab to see if this fixes the issue? |
|
I have tested it on scarthgap factory which has the necessary machinery and tests it in the lab |
ricardosalveti
approved these changes
Feb 20, 2025
|
I'll add this also to my backlog, maybe we can somehow address that in the upstream also |
|
yeah something good to address upstream |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is probably due to fact systemd-boot does not allocate any extra space for the device tree. Without the modification, because there is not any extra space, the UEFI will fail applying the overlay changes from its .dtbo files
Fixes:
References:
anduril/jetpack-nixos#111