Skip to content

feat: ensure fms-acceleration callbacks run before TrainerController #620

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 27, 2025
Merged

feat: ensure fms-acceleration callbacks run before TrainerController #620

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 10 additions & 9 deletions tuning/sft_trainer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -246,15 +246,6 @@ def train(
trainer_callbacks.append(cb)
trackers.append(t)

# Now add trainer controller callbacks if requested
if (trainer_controller_args is not None) and (
trainer_controller_args.trainer_controller_config_file is not None
):
tc_callback = TrainerControllerCallback(
trainer_controller_args.trainer_controller_config_file,
)
trainer_callbacks.append(tc_callback)

# Add any extra callback if passed by users
if additional_callbacks is not None:
for cb in additional_callbacks:
Expand Down Expand Up @@ -500,6 +491,8 @@ def train(
model
)

# Register fms-acceleration callbacks before Trainer Controller
# so that on_save() runs earlier for proper model unwrapping and checkpoint handling
if framework is not None:
accelerator = None if not is_accelerate_available() else trainer.accelerator

Expand All @@ -514,6 +507,14 @@ def train(
):
trainer.add_callback(clb)

if (trainer_controller_args is not None) and (
trainer_controller_args.trainer_controller_config_file is not None
):
tc_callback = TrainerControllerCallback(
trainer_controller_args.trainer_controller_config_file,
)
trainer.add_callback(tc_callback)

trainer.train(resume_from_checkpoint)
additional_metadata = {}
additional_metadata["added_tokens_info"] = added_tokens_dict
Expand Down