feat: add adc frontend interface - #206
Draft
IM-TechieScientist wants to merge 1 commit into
Draft
Conversation
Reviewer's GuideIntroduces a hardware-agnostic ADC frontend layer and registry, wires the existing RP2350 internal ADC through this abstraction, and refactors DSO and mixed-signal capture paths to use the new interface and capability reporting instead of depending directly on platform/adc_capture. Sequence diagram for DSO capture via ADC frontendsequenceDiagram
participant Dso as DsoInstrument
participant Frontend as AdcFrontend
participant Driver as AdcFrontendDriver_internal
participant Capture as AdcCapture
Dso->>Frontend: adc_frontend_init(config{backend=INTERNAL})
Frontend->>Frontend: adc_frontend_select_backend(INTERNAL)
Frontend->>Driver: init(config)
Driver-->>Frontend: bool
Frontend-->>Dso: bool
Dso->>Frontend: adc_frontend_run(buffer, sample_count, info)
Frontend->>Driver: run(buffer, sample_count, info)
Driver->>Capture: adc_capture_run(buffer, sample_count, capture_info)
Capture-->>Driver: bool
Driver-->>Frontend: bool
Frontend-->>Dso: bool
File-Level Changes
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Working on #201.
This PR adds a hardware agnostic ADC frontend interface for the DSO/MSO capture paths.
Summary by Sourcery
Introduce a hardware-agnostic ADC frontend layer and migrate existing capture paths to use it.
New Features:
Enhancements:
Build: