Update twitter icon by mdsaqlain1 · Pull Request #9178 · fossasia/open-event-frontend

mdsaqlain1 · 2023-12-11T18:47:58Z

Fixes #9165

Short description of what this resolves:

This pull request addresses the issue with the outdated Twitter logo on the site. The Twitter logo will be updated to X to reflect the recent changes.

Changes proposed in this pull request:

Updated the Twitter logo to X

Logo.update.-.X.mp4

Checklist

I have read the Contribution & Best practices Guide.
My branch is up-to-date with the Upstream development branch.
The acceptance, integration, unit tests, and linter pass locally with my changes
I have added tests that prove my fix is effective or that my feature works
I have added necessary documentation (if appropriate)

Currently translated at 99.9% (2552 of 2554 strings) Translation: Open Event/Open Event Frontend Translate-URL: https://hosted.weblate.org/projects/open-event/frontend/sv/ Co-authored-by: Mario Behling <mb@mariobehling.de>

* feature-9082: Enhance language dropdown button * feature-9082: Enhance language dropdown button * fix css * fix UI * fix missing header * fix missing header * fix missing header * fix missing header * fix missing header * fix missing header * avoid using css inline * feature-9082: Fix css dropdown side panel * feature-9082: Fix css dropdown side panel * feature-9082: Fix css dropdown side panel * fix-9082 language dropdown not showing up * fix-9082 language dropdown not showing up --------- Co-authored-by: Khang On - TMA <135116292+khangon@users.noreply.github.com> Co-authored-by: ntthitrinh <ntthitrinh@tma.com.vn>

…ng filtered page (fossasia#9145) * fix-7016: Link redirect of current day results in user forward to wrong filtered page * fix-7016: Link redirect of current day results in user forward to wrong filtered page

* feature-9082: Enhance language dropdown button * feature-9082: Enhance language dropdown button * fix css * fix UI * fix missing header * fix missing header * fix missing header * fix missing header * fix missing header * fix missing header * avoid using css inline * feature-9082: Fix css dropdown side panel * feature-9082: Fix css dropdown side panel * feature-9082: Fix css dropdown side panel * fix-9082 language dropdown not showing up * fix-9082 language dropdown not showing up * feature-9082: Enhance language dropdown button * feature-9082: Enhance language dropdown button --------- Co-authored-by: nnhathung <nnhathung@tma.com.vn> Co-authored-by: Khang On - TMA <135116292+khangon@users.noreply.github.com> Co-authored-by: ntthitrinh <ntthitrinh@tma.com.vn>

…ossasia#9115) * fix-9080: There was no result for searching with Ticket price 0.0 * fix-9080: There was no result for searching with Ticket price 0.0 --------- Co-authored-by: Khang On - TMA <135116292+khangon@users.noreply.github.com>

…rought Discount Codes Page. (fossasia#9144)

…ttendees page (fossasia#9078) * fix-9076: Cannot show all entries when selecting 'Show All' in View Attendees page * fix-9076: Cannot show all entries when selecting 'Show All' in View Attendees page * fix-9076: Cannot show all entries when selecting 'Show All' in View Attendees page --------- Co-authored-by: Khang On - TMA <135116292+khangon@users.noreply.github.com>

fossasia#9157) * fix-9154: [Badge Wizard] Showing <a> tag in custom field when organizer tries to add custom question to badge * fix-9154: [Badge Wizard] Showing <a> tag in custom field when organizer tries to add custom question to badge

…ssasia#9150) * feature-9020: Filter options for orders and attendees not working * feature-9020: Filter options for orders and attendees not working * feature-9020: Filter options for orders and attendees not working * feature-9020: Filter options for orders and attendees not working * feature-9020: Fix UI filter date * feature-9020: Fix UI filter date * feature-9020: Fix UI filter date at the order * feature-9020: Filter options for orders and attendees not working --------- Co-authored-by: odkhang <odkhang@tma.com.vn> Co-authored-by: Khang On - TMA <135116292+khangon@users.noreply.github.com>

* feature-9125: Fix top menu for mobile screens * feature-9125: Fix top menu for mobile screens * feature-9125: Fix top menu for mobile screens * feature-9125: Fix top menu for mobile screens * feature-9125: Fix top menu for mobile screens * feature-9125: Fix top menu for mobile screens * feature-9125: Fix top menu for mobile screens --------- Co-authored-by: ntthitrinh <ntthitrinh@tma.com.vn>

…9159) * fix-9127: Top align table content on manage event dashboard * fix-9127: Top align table content on manage event dashboard

* feature-8684: Add option to tag attendees * feature-8684: Add option to tag attendees * feature-8684: Add option to tag attendees * feature-8684: Add option to tag attendees * feature-8684: Add option to tag attendees * feature-8684: Add option to tag attendees * feature-8684: Add option to tag attendees * feature-8684: Add option to tag attendees * feature-8684: Add option to tag attendees * feature-8684: Add option to tag attendees * feature-8684: Add option to tag attendees * feature-8684: Add option to tag attendees * feature-8684: Add option to tag attendees * feature-8684: Merge code development

…n full (fossasia#9160) * fix-9140: The value of the status dropdown list cannot be displayed in full * fix-9140: The value of the status dropdown list cannot be displayed in full

* feature-9082: Enhance language dropdown button * feature-9082: Enhance language dropdown button * fix css * fix UI * fix missing header * fix missing header * fix missing header * fix missing header * fix missing header * fix missing header * avoid using css inline * feature-9082: Fix css dropdown side panel * feature-9082: Fix css dropdown side panel * feature-9082: Fix css dropdown side panel * fix-9082 language dropdown not showing up * fix-9082 language dropdown not showing up * feature-9082: Enhance language dropdown button * feature-9082: Enhance language dropdown button * feature-9082: Enhance language dropdown button --------- Co-authored-by: nnhathung <nnhathung@tma.com.vn> Co-authored-by: Khang On - TMA <135116292+khangon@users.noreply.github.com> Co-authored-by: ntthitrinh <ntthitrinh@tma.com.vn>

* feature-9082: Enhance language dropdown button * feature-9082: Enhance language dropdown button * fix css * fix UI * fix missing header * fix missing header * fix missing header * fix missing header * fix missing header * fix missing header * avoid using css inline * feature-9082: Fix css dropdown side panel * feature-9082: Fix css dropdown side panel * feature-9082: Fix css dropdown side panel * fix-9082 language dropdown not showing up * fix-9082 language dropdown not showing up * feature-9082: Enhance language dropdown button * feature-9082: Enhance language dropdown button * feature-9082: Enhance language dropdown button * feature-9082: Enhance language dropdown button --------- Co-authored-by: nnhathung <nnhathung@tma.com.vn> Co-authored-by: Khang On - TMA <135116292+khangon@users.noreply.github.com> Co-authored-by: ntthitrinh <ntthitrinh@tma.com.vn>

…in CSV (fossasia#9138)

Currently translated at 100.0% (2554 of 2554 strings) Translation: Open Event/Open Event Frontend Translate-URL: https://hosted.weblate.org/projects/open-event/frontend/sv/ Co-authored-by: Kristoffer Grundström <swedishsailfishosuser@tutanota.com>

* Translated using Weblate (Swedish) Currently translated at 100.0% (2554 of 2554 strings) Translation: Open Event/Open Event Frontend Translate-URL: https://hosted.weblate.org/projects/open-event/frontend/sv/ * Translated using Weblate (Swedish) Currently translated at 99.9% (2552 of 2554 strings) Translation: Open Event/Open Event Frontend Translate-URL: https://hosted.weblate.org/projects/open-event/frontend/sv/ * Translated using Weblate (Spanish) Currently translated at 100.0% (2554 of 2554 strings) Translation: Open Event/Open Event Frontend Translate-URL: https://hosted.weblate.org/projects/open-event/frontend/es/ * Translated using Weblate (Polish) Currently translated at 100.0% (2554 of 2554 strings) Translation: Open Event/Open Event Frontend Translate-URL: https://hosted.weblate.org/projects/open-event/frontend/pl/ --------- Co-authored-by: Kristoffer Grundström <swedishsailfishosuser@tutanota.com> Co-authored-by: gallegonovato <fran-carro@hotmail.es> Co-authored-by: Eryk Michalak <gnu.ewm@protonmail.com>

This reverts commit 666021d.

vercel · 2023-12-11T18:48:04Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
open-event-frontend	❌ Failed (Inspect)			Dec 14, 2023 8:23am

mdsaqlain1 · 2023-12-11T19:13:29Z

Hi @norbusan , @mariobehling , @cweitat ,
We have completed ticket #9165, which addresses the issue with the outdated Twitter logo on the site. The Twitter logo has been updated to X to reflect recent changes. Please help me check and verify.

Thanks,
Mohammed Saqlain

cweitat · 2023-12-12T03:55:09Z

          {{#if this.socialLinks.twitterUrl}}
-            <a class="item" href="{{this.socialLinks.twitterUrl}}" target="_blank" rel="noopener noreferrer">
-              <i class="twitter icon"></i> {{t 'Twitter'}}
+            <a class="item" href="https://twitter.com/eventyay" target="_blank" rel="noopener noreferrer">


you shouldn't change this to hardcoded. it is supposed to be fetch from config

also your X is not to scale. refer to other icons and standardisation

Hi @cweitat,

Thank you for your feedback. I've made the necessary adjustments to address your concerns:

Dynamic Configuration: I've revised the code to ensure that the Twitter logo is fetched from the configuration, as opposed to being hardcoded. This ensures better flexibility and adherence to project standards.

Icon Scaling: I've reviewed the scaling of the X icon and adjusted it to align with the standardization of other icons. It should now be more in line with the established design principles.

Please take a moment to review the latest changes in the pull request. Your continued guidance is highly appreciated.

Best regards,
Mohammed Saqlain

mdsaqlain1 · 2023-12-22T05:40:38Z

Hi @norbusan , @mariobehling , @cweitat
I've made the necessary adjustments to address your concerns

Please take a moment to review the latest changes in the pull request. Your continued guidance is highly appreciated.

weblate and others added 21 commits August 18, 2023 02:21

Translated using Weblate (Swedish) (fossasia#9141)

f04f570

Currently translated at 99.9% (2552 of 2554 strings) Translation: Open Event/Open Event Frontend Translate-URL: https://hosted.weblate.org/projects/open-event/frontend/sv/ Co-authored-by: Mario Behling <mb@mariobehling.de>

fix-7016: Link redirect of current day results in user forward to wro…

498add5

…ng filtered page (fossasia#9145) * fix-7016: Link redirect of current day results in user forward to wrong filtered page * fix-7016: Link redirect of current day results in user forward to wrong filtered page

fix-9139: The Expired tab of Access Codes Page has navigated wrong th…

2ba0fe3

…rought Discount Codes Page. (fossasia#9144)

fix-9127:Top align table content on manage event dashboard (fossasia#…

92dafd6

…9159) * fix-9127: Top align table content on manage event dashboard * fix-9127: Top align table content on manage event dashboard

fix 9140: The value of the status dropdown list cannot be displayed i…

e811c76

…n full (fossasia#9160) * fix-9140: The value of the status dropdown list cannot be displayed in full * fix-9140: The value of the status dropdown list cannot be displayed in full

feature-9065: Track when attendees login and join an event virtually …

d2861b9

…in CSV (fossasia#9138)

Update Twitter icon to X

666021d

Revert "Update Twitter icon to X"

dfdeadf

This reverts commit 666021d.

Update Twitter icon to X

90f23e9

vercel Bot had a problem deploying to Preview December 11, 2023 18:48 Failure

cweitat suggested changes Dec 12, 2023

View reviewed changes

Address feedback: fetch from config, scale correction

c923598

vercel Bot had a problem deploying to Preview December 14, 2023 08:23 Failure

mdsaqlain1 requested a review from cweitat December 15, 2023 09:20

norbusan force-pushed the development branch from 12b957b to 849e964 Compare March 26, 2024 06:58

mariobehling closed this Jan 11, 2026

Navigation Menu

Repository navigation

Update twitter icon - #9178

Update twitter icon#9178
mdsaqlain1 wants to merge 22 commits into
fossasia:developmentfrom
mdsaqlain1:update-twitter-icon

mdsaqlain1 commented Dec 11, 2023

Uh oh!

vercel Bot commented Dec 11, 2023 •

edited

Loading

Uh oh!

mdsaqlain1 commented Dec 11, 2023

Uh oh!

cweitat Dec 12, 2023

Uh oh!

cweitat Dec 12, 2023

Uh oh!

mdsaqlain1 Dec 14, 2023

Uh oh!

mdsaqlain1 commented Dec 22, 2023

Uh oh!

This branch had an error being deployed

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Conversation

mdsaqlain1 commented Dec 11, 2023

Short description of what this resolves:

Changes proposed in this pull request:

Checklist

Uh oh!

vercel Bot commented Dec 11, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mdsaqlain1 commented Dec 11, 2023

Uh oh!

cweitat Dec 12, 2023

Choose a reason for hiding this comment

Uh oh!

cweitat Dec 12, 2023

Choose a reason for hiding this comment

Uh oh!

mdsaqlain1 Dec 14, 2023

Choose a reason for hiding this comment

Uh oh!

mdsaqlain1 commented Dec 22, 2023

Uh oh!

This branch had an error being deployed

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

vercel Bot commented Dec 11, 2023 •

edited

Loading