-
Notifications
You must be signed in to change notification settings - Fork 23
fix: failing ios builds #291
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Reviewer's guide (collapsed on small PRs)Reviewer's GuideDisables Flutter action caching in iOS-related GitHub Actions workflows to address failing iOS builds and screenshot jobs. Flow diagram for iOS workflow setup with Flutter cache disabledflowchart TD
A[Workflow_start_ios_or_screenshot_job] --> B[Checkout_repository]
B --> C[Set_up_Flutter_with_cache_false]
C --> D[Update_Podfile]
D --> E[Install_Dependencies_and_Build]
E --> F{Job_type}
F -- ios_build --> G[Run_iOS_build]
F -- screenshot_ipad --> H[Run_iPad_screenshot_tests]
F -- screenshot_iphone --> I[Run_iPhone_screenshot_tests]
G --> J[Upload_artifacts]
H --> J
I --> J
J --> K[Job_complete]
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey there - I've reviewed your changes - here's some feedback:
- Consider adding a short comment in the workflows explaining why Flutter caching is disabled so future changes don’t inadvertently re-enable it and reintroduce the build issue.
- If the cache behavior may vary across environments, you might want to wire this through an input or environment variable instead of hardcoding
cache: falseso it’s easier to toggle without changing the workflows.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- Consider adding a short comment in the workflows explaining why Flutter caching is disabled so future changes don’t inadvertently re-enable it and reintroduce the build issue.
- If the cache behavior may vary across environments, you might want to wire this through an input or environment variable instead of hardcoding `cache: false` so it’s easier to toggle without changing the workflows.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Build StatusBuild successful. APKs to test: https://github.com/fossasia/magic-epaper-app/actions/runs/20008267318/artifacts/4790938794. Screenshots |







-1_display_selection.png?raw=true)
-2_sidebar.png?raw=true)
-3_ndef_screen.png?raw=true)
-4_filter_selection.png?raw=true)
-5_barcode_screen.png?raw=true)
-6_Barcode_added.png?raw=true)
-7_Templates_screen.png?raw=true)
Summary by Sourcery
Disable Flutter cache usage in GitHub Actions workflows for iOS builds and screenshots to address failing iOS build pipelines.
CI: