Skip to content

Conversation

@Vishveshwara
Copy link
Contributor

@Vishveshwara Vishveshwara commented Dec 7, 2025

Summary by Sourcery

Disable Flutter cache usage in GitHub Actions workflows for iOS builds and screenshots to address failing iOS build pipelines.

CI:

  • Turn off Flutter action caching in the iOS build GitHub Action.
  • Turn off Flutter action caching in the iPad screenshot GitHub Action.
  • Turn off Flutter action caching in the iPhone screenshot GitHub Action.

@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Dec 7, 2025

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Disables Flutter action caching in iOS-related GitHub Actions workflows to address failing iOS builds and screenshot jobs.

Flow diagram for iOS workflow setup with Flutter cache disabled

flowchart TD
  A[Workflow_start_ios_or_screenshot_job] --> B[Checkout_repository]
  B --> C[Set_up_Flutter_with_cache_false]
  C --> D[Update_Podfile]
  D --> E[Install_Dependencies_and_Build]
  E --> F{Job_type}
  F -- ios_build --> G[Run_iOS_build]
  F -- screenshot_ipad --> H[Run_iPad_screenshot_tests]
  F -- screenshot_iphone --> I[Run_iPhone_screenshot_tests]
  G --> J[Upload_artifacts]
  H --> J
  I --> J
  J --> K[Job_complete]
Loading

File-Level Changes

Change Details Files
Disable Flutter SDK caching in the shared iOS build GitHub Action.
  • Set the flutter-action cache flag to false in the reusable iOS workflow
  • Ensure Flutter is always freshly resolved based on flutter-version-file
.github/actions/ios/action.yml
Disable Flutter SDK caching in screenshot GitHub Actions for iPad and iPhone.
  • Set the flutter-action cache flag to false in the iPad screenshot workflow
  • Set the flutter-action cache flag to false in the iPhone screenshot workflow
  • Align screenshot workflows with the main iOS workflow caching behavior
.github/actions/screenshot-ipad/action.yml
.github/actions/screenshot-iphone/action.yml

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there - I've reviewed your changes - here's some feedback:

  • Consider adding a short comment in the workflows explaining why Flutter caching is disabled so future changes don’t inadvertently re-enable it and reintroduce the build issue.
  • If the cache behavior may vary across environments, you might want to wire this through an input or environment variable instead of hardcoding cache: false so it’s easier to toggle without changing the workflows.
Prompt for AI Agents
Please address the comments from this code review:

## Overall Comments
- Consider adding a short comment in the workflows explaining why Flutter caching is disabled so future changes don’t inadvertently re-enable it and reintroduce the build issue.
- If the cache behavior may vary across environments, you might want to wire this through an input or environment variable instead of hardcoding `cache: false` so it’s easier to toggle without changing the workflows.

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@github-actions
Copy link
Contributor

github-actions bot commented Dec 7, 2025

Build Status

Build successful. APKs to test: https://github.com/fossasia/magic-epaper-app/actions/runs/20008267318/artifacts/4790938794.

Screenshots

Android Screenshots
iPhone Screenshots
iPad Screenshots

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant