-
Notifications
You must be signed in to change notification settings - Fork 1
chore: align plugin against enext branch #5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: enext
Are you sure you want to change the base?
chore: align plugin against enext branch #5
Conversation
Reviewer's GuideAligns all module imports, logging namespaces, plugin metadata, migration references, and log action types from pretix.* to eventyay.* to conform with the enext eventyay module structure. Entity relationship diagram for updated ReferencedPayPalObject modelerDiagram
ReferencedPayPalObject {
string reference
FK Order order
FK OrderPayment payment
}
Order ||--o{ ReferencedPayPalObject : "has"
OrderPayment ||--o{ ReferencedPayPalObject : "has"
Class diagram for updated PaypalPluginApp and plugin metaclassDiagram
class PaypalPluginApp {
name : str = "eventyay_paypal"
verbose_name : str = _("PayPal")
}
class EventyayPluginMeta {
name : str = _("PayPal")
author : str = "eventyay"
version : str = __version__
}
PaypalPluginApp <|-- EventyayPluginMeta
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey there - I've reviewed your changes - here's some feedback:
- Ensure that the migration dependency change from 'pretixbase' to 'base' does not disrupt the existing migration graph or require a data migration for existing databases.
- Double-check that updating the logger names to 'eventyay.plugins.eventyay_paypal' matches your logging configuration so no log entries are dropped.
- Verify that renaming the inner plugin class from PretixPluginMeta to EventyayPluginMeta is still recognized by your plugin loader and won’t break plugin discovery.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- Ensure that the migration dependency change from 'pretixbase' to 'base' does not disrupt the existing migration graph or require a data migration for existing databases.
- Double-check that updating the logger names to 'eventyay.plugins.eventyay_paypal' matches your logging configuration so no log entries are dropped.
- Verify that renaming the inner plugin class from PretixPluginMeta to EventyayPluginMeta is still recognized by your plugin loader and won’t break plugin discovery.
## Individual Comments
### Comment 1
<location> `eventyay_paypal/apps.py:8-9` </location>
<code_context>
from django.apps import AppConfig
from django.utils.translation import gettext_lazy as _
from . import __version__
try:
from eventyay.base.plugins import PluginConfig
except ImportError:
raise RuntimeError("Python package 'paypal' is not installed.")
</code_context>
<issue_to_address>
**suggestion (code-quality):** Explicitly raise from a previous error ([`raise-from-previous-error`](https://docs.sourcery.ai/Reference/Default-Rules/suggestions/raise-from-previous-error/))
```suggestion
except ImportError as e:
raise RuntimeError("Python package 'paypal' is not installed.") from e
```
</issue_to_address>
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
except ImportError: | ||
raise RuntimeError("Python package 'paypal' is not installed.") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
suggestion (code-quality): Explicitly raise from a previous error (raise-from-previous-error
)
except ImportError: | |
raise RuntimeError("Python package 'paypal' is not installed.") | |
except ImportError as e: | |
raise RuntimeError("Python package 'paypal' is not installed.") from e |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please make this PR against the enext branch.
The PR is made against enext branch only. |
I think you misunderstand. https://github.com/fossasia/eventyay-tickets-paypal/tree/enext here in this repo. |
This PR is a part of fossasia/eventyay-tickets#1030
Summary by Sourcery
Align PayPal plugin references with the Eventyay namespace by replacing pretix imports, log identifiers, and metadata to use eventyay equivalents
Enhancements: