fix: bump nodemailer to ^9.0.1 to resolve GHSA-p6gq-j5cr-w38f#51
Open
pddivine wants to merge 1 commit into
Open
fix: bump nodemailer to ^9.0.1 to resolve GHSA-p6gq-j5cr-w38f#51pddivine wants to merge 1 commit into
pddivine wants to merge 1 commit into
Conversation
Nodemailer <=9.0.0 allowed the message-level `raw` option to bypass `disableFileAccess`/`disableUrlAccess`, enabling arbitrary file read and SSRF in the delivered message (CVSS 7.1, high). The fix landed in nodemailer 9.0.1. preview-email uses nodemailer only via `streamTransport` (in index.js) and `jsonTransport` (in tests) and does not fetch remote attachments, use OAuth2, or proxy HTTPS, so the 9.0.0 TLS-default breaking change is not relevant here. The full test suite passes against 9.0.1 with no code changes required.
|
@titanism please review this, this impacts my work as well |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Bumps
nodemailerfrom^8.0.4to^9.0.1to resolve a high-severity advisory.Vulnerability
GHSA-p6gq-j5cr-w38f (CVSS 7.1, high) — nodemailer
<=9.0.0allowed the message-levelrawoption to bypassdisableFileAccess/disableUrlAccess, enabling arbitrary file read and full-response SSRF in the delivered message. Fixed in nodemailer 9.0.1.Confirmed locally with
npm audit:9.x breaking-change assessment
The single breaking change in nodemailer 9.0.0 is that HTTPS requests fetching remote content (attachment
href/pathURLs, OAuth2 token endpoints, HTTP/HTTPS proxyCONNECT) now validate TLS certificates by default.preview-emailuses nodemailer only via:streamTransport: trueinindex.jsto serialize a message to a buffer in-process, andjsonTransport: truein the test suite.Neither path fetches remote attachments, uses OAuth2, or proxies HTTPS, so the stricter TLS default has no behavioral impact here. No code changes are required.
The
engines.nodefield is unaffected: nodemailer 9.x still declaresnode: >=6.0.0, well below this package's existing>=14.Test plan
npm install— installs nodemailer 9.0.1npm test— 8/8 tests pass (lint + ava)npm audit— nodemailer no longer appears in the report