feat(date/time field): change step to 10 if shift is pressed#158
Draft
ahmadalfy wants to merge 1 commit intoformwerkjs:mainfrom
Draft
feat(date/time field): change step to 10 if shift is pressed#158ahmadalfy wants to merge 1 commit intoformwerkjs:mainfrom
ahmadalfy wants to merge 1 commit intoformwerkjs:mainfrom
Conversation
|
Member
|
Looks good so far, we just need tests and a patch changeset file which you can generate with |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Is it wise to merge
incrementanddecrementinto one function, since their implementation is exactly the same?Or maybe let the step be a number (e.g.
10, not-10) and change the implementation to convert it to negative:Also, I believe the current tests are flaky and gives different results based on the time of the year when the tests are run. For example, current tests will fail if you run it in December because the increment will increase both the month and the year.
I didn't update the tests because this issue needs to be resolved first. I tried setting the date to an absolute value then I stopped because I'd like to know what you think first.
closes #156