Skip to content

Conversation

@flemzord
Copy link
Member

No description provided.

@flemzord flemzord requested a review from a team as a code owner October 16, 2025 12:37
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Oct 16, 2025

Caution

Review failed

The pull request is closed.

Walkthrough

Major infrastructure cleanup removing entire testing and development frameworks: benchmark tests (k6-based load testing), JavaScript/TypeScript load testing suite, integration tests (Ginkgo/Gomega), and local Docker-based development configurations. All related tooling, build scripts, and helper libraries are eliminated.

Changes

Cohort / File(s) Summary
Root Configuration
.envrc, CODEOWNERS
Removed environment variable setup for builds and backend code ownership designation.
Benchmark Infrastructure
tests/benchmarks/.*, tests/benchmarks/Earthfile, tests/benchmarks/README.md, tests/benchmarks/extension/extension.go, tests/benchmarks/tools/.*
Deleted entire k6 benchmark framework: extension service, Earthfile build config, database setup scripts, and gitignore rules.
Benchmark Test Suites & Scripts
tests/benchmarks/scripts/webpack.config.js, tests/benchmarks/scripts/src/generators/.*, tests/benchmarks/scripts/src/options.js, tests/benchmarks/scripts/src/steps/.*, tests/benchmarks/scripts/benchs/.*
Removed k6 benchmark test definitions, webpack bundler, transaction/account/balance test steps, and generator utilities.
Load Testing Framework
tests/loadtesting/.babelrc, tests/loadtesting/.eslintrc.js, tests/loadtesting/.gitignore, tests/loadtesting/.yarnclean, tests/loadtesting/Dockerfile, tests/loadtesting/README.md, tests/loadtesting/webpack.config.js
Deleted load testing configuration and build tooling (Babel, ESLint, webpack).
Load Testing Client Libraries
tests/loadtesting/libs/client/.*, tests/loadtesting/libs/config/index.ts, tests/loadtesting/libs/core/.*
Removed versioned ledger API client implementations (1.3–1.7), server version discovery, and test matrix helpers.
Load Testing Test Suites
tests/loadtesting/src/ledger/.*, tests/loadtesting/tests/.*
Deleted ledger operation test scenarios (accounts, transactions, infos, stats, write operations) and test orchestration.
Integration Testing Infrastructure
tests/integration/Earthfile, tests/integration/temporalite.Dockerfile, tests/integration/doc.go
Removed integration test build configuration and Temporalite Docker image builder.
Integration Testing Internals
tests/integration/internal/config.go, tests/integration/internal/env.go, tests/integration/internal/events.go, tests/integration/internal/gateway.go, tests/integration/internal/helpers.go, tests/integration/internal/init.go, tests/integration/internal/module.go, tests/integration/internal/service.go, tests/integration/internal/test.go
Deleted test environment lifecycle, service orchestration, module builder, event utilities, gateway HTTP routing, and test initialization hooks.
Integration Test Modules
tests/integration/internal/modules/auth.go, tests/integration/internal/modules/ledger.go, tests/integration/internal/modules/orchestration.go, tests/integration/internal/modules/payments.go, tests/integration/internal/modules/reconciliation.go, tests/integration/internal/modules/search.go, tests/integration/internal/modules/wallets.go, tests/integration/internal/modules/webhooks.go
Removed service module definitions for all integrated components (auth, ledger, payments, orchestration, reconciliation, search, wallets, webhooks).
Integration Test Suites
tests/integration/suite/orchestration-*.go, tests/integration/suite/reconciliation-policy-create-list.go, tests/integration/suite/suite_test.go, tests/integration/suite/utils.go
Deleted end-to-end integration test scenarios for orchestration workflows/triggers and reconciliation policy management.
Local Development Setup
.local/gateway/Caddyfile, .local/postgres/multi-db.sh
Removed local Caddyfile API gateway routing configuration and PostgreSQL multi-database initialization script.

Estimated code review effort

🎯 4 (Complex) | ⏱️ ~75 minutes

Rationale: Extremely large scope spanning hundreds of files across heterogeneous frameworks (k6, Jest, Ginkgo, Docker, webpack, Babel). While individual changes are straightforward deletions, the aggregate volume, diversity of technologies (Go, TypeScript, shell, configuration formats), and need to verify no cross-references remain in retained code warrant comprehensive review.

Poem

🐰 Farewell, dear tests and benchmarks bright,
Load-testing suites and fixtures' might,
Integration scaffolds cleaned away,
Development clutter finds no stay,
Simpler meadows, swifter flights!

✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch chore/clean

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

Disabled knowledge base sources:

  • Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 3c1ca75 and eb6c89e.

⛔ Files ignored due to path filters (26)
  • .local/docker-compose.yml is excluded by !**/*.yml
  • .local/process-compose.yaml is excluded by !**/*.yaml
  • codecov.yml is excluded by !**/*.yml
  • docker-compose.yml is excluded by !**/*.yml
  • tests/benchmarks/Taskfile.yaml is excluded by !**/*.yaml
  • tests/benchmarks/extension/go.mod is excluded by !**/*.mod
  • tests/benchmarks/extension/go.sum is excluded by !**/*.sum, !**/*.sum
  • tests/benchmarks/scripts/package.json is excluded by !**/*.json
  • tests/benchmarks/scripts/yarn.lock is excluded by !**/yarn.lock, !**/*.lock, !**/*.lock
  • tests/benchmarks/tools/docker-compose.yml is excluded by !**/*.yml
  • tests/benchmarks/tools/otel-collector-config.yaml is excluded by !**/*.yaml
  • tests/benchmarks/tools/prometheus.yaml is excluded by !**/*.yaml
  • tests/benchmarks/tools/provisioning/dashboards/dashboards.yml is excluded by !**/*.yml
  • tests/benchmarks/tools/provisioning/dashboards/default/k6.json is excluded by !**/*.json
  • tests/benchmarks/tools/provisioning/dashboards/default/perf.json is excluded by !**/*.json
  • tests/benchmarks/tools/provisioning/dashboards/default/rps.json is excluded by !**/*.json
  • tests/benchmarks/tools/provisioning/datasources/datasource.yml is excluded by !**/*.yml
  • tests/integration/Taskfile.yaml is excluded by !**/*.yaml
  • tests/integration/docker-compose.yml is excluded by !**/*.yml
  • tests/integration/go.mod is excluded by !**/*.mod
  • tests/integration/go.sum is excluded by !**/*.sum, !**/*.sum
  • tests/loadtesting/Taskfile.yaml is excluded by !**/*.yaml
  • tests/loadtesting/docker-compose.ledger.yml is excluded by !**/*.yml
  • tests/loadtesting/package.json is excluded by !**/*.json
  • tests/loadtesting/tsconfig.json is excluded by !**/*.json
  • tests/loadtesting/yarn.lock is excluded by !**/yarn.lock, !**/*.lock, !**/*.lock
📒 Files selected for processing (77)
  • .envrc (0 hunks)
  • .local/gateway/Caddyfile (0 hunks)
  • .local/postgres/multi-db.sh (0 hunks)
  • CODEOWNERS (0 hunks)
  • tests/benchmarks/.gitignore (0 hunks)
  • tests/benchmarks/Earthfile (0 hunks)
  • tests/benchmarks/README.md (0 hunks)
  • tests/benchmarks/extension/extension.go (0 hunks)
  • tests/benchmarks/scripts/.gitignore (0 hunks)
  • tests/benchmarks/scripts/benchs/ledger-v2.js (0 hunks)
  • tests/benchmarks/scripts/src/generators/simple.numscript (0 hunks)
  • tests/benchmarks/scripts/src/generators/transactions.js (0 hunks)
  • tests/benchmarks/scripts/src/options.js (0 hunks)
  • tests/benchmarks/scripts/src/steps/account.js (0 hunks)
  • tests/benchmarks/scripts/src/steps/aggregateBalances.js (0 hunks)
  • tests/benchmarks/scripts/src/steps/balances.js (0 hunks)
  • tests/benchmarks/scripts/src/steps/transactions.js (0 hunks)
  • tests/benchmarks/scripts/webpack.config.js (0 hunks)
  • tests/benchmarks/tools/.env (0 hunks)
  • tests/benchmarks/tools/postgresql.conf (0 hunks)
  • tests/integration/Earthfile (0 hunks)
  • tests/integration/doc.go (0 hunks)
  • tests/integration/internal/config.go (0 hunks)
  • tests/integration/internal/env.go (0 hunks)
  • tests/integration/internal/events.go (0 hunks)
  • tests/integration/internal/gateway.go (0 hunks)
  • tests/integration/internal/helpers.go (0 hunks)
  • tests/integration/internal/init.go (0 hunks)
  • tests/integration/internal/module.go (0 hunks)
  • tests/integration/internal/modules/auth.go (0 hunks)
  • tests/integration/internal/modules/ledger.go (0 hunks)
  • tests/integration/internal/modules/orchestration.go (0 hunks)
  • tests/integration/internal/modules/payments.go (0 hunks)
  • tests/integration/internal/modules/reconciliation.go (0 hunks)
  • tests/integration/internal/modules/search.go (0 hunks)
  • tests/integration/internal/modules/wallets.go (0 hunks)
  • tests/integration/internal/modules/webhooks.go (0 hunks)
  • tests/integration/internal/service.go (0 hunks)
  • tests/integration/internal/test.go (0 hunks)
  • tests/integration/suite/orchestration-triggers.go (0 hunks)
  • tests/integration/suite/orchestration-workflows-create.go (0 hunks)
  • tests/integration/suite/orchestration-workflows-execute-with-error.go (0 hunks)
  • tests/integration/suite/orchestration-workflows-execute.go (0 hunks)
  • tests/integration/suite/orchestration-workflows-list.go (0 hunks)
  • tests/integration/suite/orchestration-workflows-soft-delete.go (0 hunks)
  • tests/integration/suite/reconciliation-policy-create-list.go (0 hunks)
  • tests/integration/suite/suite_test.go (0 hunks)
  • tests/integration/suite/utils.go (0 hunks)
  • tests/integration/temporalite.Dockerfile (0 hunks)
  • tests/loadtesting/.babelrc (0 hunks)
  • tests/loadtesting/.eslintrc.js (0 hunks)
  • tests/loadtesting/.gitignore (0 hunks)
  • tests/loadtesting/.yarnclean (0 hunks)
  • tests/loadtesting/Dockerfile (0 hunks)
  • tests/loadtesting/README.md (0 hunks)
  • tests/loadtesting/libs/client/1_3/client.ts (0 hunks)
  • tests/loadtesting/libs/client/1_3/index.ts (0 hunks)
  • tests/loadtesting/libs/client/1_4/client.ts (0 hunks)
  • tests/loadtesting/libs/client/1_4/index.ts (0 hunks)
  • tests/loadtesting/libs/client/1_5/client.ts (0 hunks)
  • tests/loadtesting/libs/client/1_5/index.ts (0 hunks)
  • tests/loadtesting/libs/client/1_7/client.ts (0 hunks)
  • tests/loadtesting/libs/client/1_7/index.ts (0 hunks)
  • tests/loadtesting/libs/client/base/index.ts (0 hunks)
  • tests/loadtesting/libs/client/index.ts (0 hunks)
  • tests/loadtesting/libs/config/index.ts (0 hunks)
  • tests/loadtesting/libs/core/expectations.ts (0 hunks)
  • tests/loadtesting/libs/core/index.ts (0 hunks)
  • tests/loadtesting/libs/core/versions.ts (0 hunks)
  • tests/loadtesting/src/ledger/accounts-test.ts (0 hunks)
  • tests/loadtesting/src/ledger/infos-test.ts (0 hunks)
  • tests/loadtesting/src/ledger/stats-test.ts (0 hunks)
  • tests/loadtesting/src/ledger/transactions-test.ts (0 hunks)
  • tests/loadtesting/src/ledger/write-transactions-test.ts (0 hunks)
  • tests/loadtesting/tests/ledger-all.ts (0 hunks)
  • tests/loadtesting/tests/ledger-write.ts (0 hunks)
  • tests/loadtesting/webpack.config.js (0 hunks)

Comment @coderabbitai help to get the list of available commands and usage tips.

@flemzord flemzord enabled auto-merge October 16, 2025 12:38
@flemzord flemzord added this pull request to the merge queue Oct 16, 2025
Merged via the queue into release/v3.0 with commit ca1e676 Oct 16, 2025
2 of 3 checks passed
@flemzord flemzord deleted the chore/clean branch October 16, 2025 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants