fix(docker): add timezones database in base and scratch images

[sylr]

No description provided.

[coderabbitai]

Walkthrough

The Dockerfile modifies the base stage to install tzdata and set DEBIAN_FRONTEND=noninteractive, and updates the final scratch stage to copy zoneinfo data. The certs stage remains functionally the same, with formatting-only adjustments.

Changes

Cohort / File(s)	Change Summary
Docker build stages base.Dockerfile	- Base: add tzdata; set DEBIAN_FRONTEND=noninteractive for apt install. - Final (scratch): also copy /usr/share/zoneinfo from base; continue copying CA certificates from certs stage. - Certs stage: header capitalization/formatting only; no functional change.

Sequence Diagram(s)

sequenceDiagram
    autonumber
    participant Base as Base Stage
    participant Certs as Certs Stage
    participant Final as Final (scratch) Stage

    Note over Base: Build base image
    Base->>Base: apt-get install ca-certificates, curl, tzdata\n(DEBIAN_FRONTEND=noninteractive)

    Note over Certs: Extract certificates
    Certs->>Certs: Prepare /etc/ssl/certs

    Note over Final: Assemble scratch image
    Final->>Base: COPY /usr/share/zoneinfo
    Final->>Certs: COPY /etc/ssl/certs
    Note right of Final: Result: scratch image with CA certs + timezone data

Loading

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

I thump my paw at UTC’s chime,
Packed tzdata right on time.
In scratch I burrow, lean and neat,
With zoneinfo and certs to treat.
Curling ears, I ship and zoom—
Tiny layers, lots of room! 🐇✨

Pre-merge checks and finishing touches

❌ Failed checks (1 inconclusive)

Check name	Status	Explanation	Resolution
Description Check	❓ Inconclusive	The pull request contains no description, so there is no author-provided summary or context for the changes, making it impossible to assess the description’s relevance or completeness.	Please add a brief description that outlines the changes, rationale, and any important details to provide context for reviewers.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Title Check	✅ Passed	The title clearly summarizes the main change by indicating that the timezone database (tzdata) is being added to both the base and scratch Docker images, which directly reflects the modifications in the Dockerfile. It is concise, specific, and focused on the primary update without extraneous information.
Docstring Coverage	✅ Passed	No functions found in the changes. Docstring coverage check skipped.

✨ Finishing touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch tzdata

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 0

🧹 Nitpick comments (3)

base.Dockerfile (3)

2-2: Use apt-get and drop unnecessary deps to slim the layer

Switch to apt-get and --no-install-recommends; curl seems unused for producing zoneinfo. Smaller, more reproducible.

-RUN apt update && DEBIAN_FRONTEND=noninteractive apt install -y ca-certificates curl tzdata && rm -rf /var/lib/apt/lists/*
+RUN apt-get update \
+ && DEBIAN_FRONTEND=noninteractive apt-get install -y --no-install-recommends ca-certificates tzdata \
+ && rm -rf /var/lib/apt/lists/*

If curl is actually needed later in the build, please confirm.

---

4-6: Pin Alpine and use --no-cache for reproducibility and smaller layers

Avoid mutable latest and apk cache.

-FROM alpine:latest AS certs
+FROM alpine:3.20.3 AS certs
-RUN apk --update add ca-certificates
+RUN apk add --no-cache ca-certificates

---

7-9: LGTM; zoneinfo in scratch is correct. Optional consolidation

Copying /usr/share/zoneinfo fixes Go/POSIX tz lookups in scratch. Consider consolidating certs+tzdata into a single Alpine stage to drop the Ubuntu stage altogether.

Example:

FROM alpine:3.20.3 AS runner-deps
RUN apk add --no-cache ca-certificates tzdata

FROM scratch
COPY --from=runner-deps /etc/ssl/certs/ca-certificates.crt /etc/ssl/certs/ca-certificates.crt
COPY --from=runner-deps /usr/share/zoneinfo /usr/share/zoneinfo

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

Disabled knowledge base sources:

• Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 53aba7e and 10b5096.

📒 Files selected for processing (1)

• base.Dockerfile (1 hunks)