fix: provide database connection options to fx container for circuit breaker

[flemzord]

Add fx.Supply(connectionOptions) to cmd/serve.go to provide database connection options to the Fx container.

The Circuit Breaker storage module required *bunconnect.ConnectionOptions as an Fx dependency but it was not being supplied, preventing it from creating its DB connection. This change resolves the dependency injection issue.

---

 

[cursor]

Cursor Agent can help with this pull request. Just @cursor in comments and I'll start working on changes in this branch.
_{Learn more about Cursor Agents}

[coderabbitai]

Walkthrough

The serve command now retrieves Bun database connection options from command flags using bunconnect.ConnectionOptionsFromFlags(cmd) and injects the resulting options into the fx dependency injection container via fx.Supply(connectionOptions).

Changes

Cohort / File(s)	Summary
Serve command connection setup cmd/serve.go	Retrieves Bun connection options from command flags with error handling; injects connection options into fx application dependency graph

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Poem

🐰 Flags now flow to Bun with care,
Options bundled, injected fair,
Dependency threads pull tight,
The serve command feels just right! 🌿✨

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	You can run @coderabbitai generate docstrings to improve docstring coverage.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly and specifically describes the main change: providing database connection options to the Fx container for the circuit breaker module.
Description check	✅ Passed	The description is directly related to the changeset, explaining the problem (missing dependency injection) and the solution (adding fx.Supply) in clear terms.

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch cursor/circuit-breaker-db-connection-d040

---

📜 Recent review details

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Disabled knowledge base sources:

• Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between a334346 and a78c108.

📒 Files selected for processing (1)

• cmd/serve.go

🔇 Additional comments (2)

cmd/serve.go (2)

46-49: LGTM! Connection options retrieval is properly implemented.

The code correctly retrieves database connection options from command flags with appropriate error handling. The placement before the fx container setup ensures the options are available when needed.

---

55-55: Clarify the purpose of this dependency supply.

The fx.Supply(connectionOptions) supplies a value type, which differs from the pattern in cmd/root.go (line 101) that uses fx.Provide(func() *bunconnect.ConnectionOptions {...}) to supply a pointer. Additionally, commonOptions already includes bunconnect.Module(*connectionOptions, ...) on line 95, which should provide the necessary database connection setup. The justification mentioning a "Circuit Breaker storage module" cannot be verified in the codebase. Clarify why this additional supply is needed given that commonOptions is already included, and whether the value vs. pointer type difference matters for any consuming modules.

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}