fix: detect approval via current labels and allow unpaused nodes to execute#71
Open
eshulman2 wants to merge 2 commits into
Open
fix: detect approval via current labels and allow unpaused nodes to execute#71eshulman2 wants to merge 2 commits into
eshulman2 wants to merge 2 commits into
Conversation
…xecute Two fixes for stuck approval gates: 1. When changelog-based label detection fails (e.g. user changes labels in two separate steps), fall back to checking the ticket's current labels. If the matching -approved label is present, treat as approved. 2. When a workflow is at a non-gate execution node with is_paused=false (e.g. after a checkpoint patch), allow it to proceed without requiring a signal. Gate nodes and CI-waiting nodes still require explicit signals. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes two issues that caused AISOS-721 to get stuck at
prd_approval_gate:Label-based approval fallback: The approval detection only checked Jira changelog transitions (
fromString→toString), which fails when users change labels in two steps (remove pending, then add approved). Now falls back to checking the ticket's current labels — if the matching-approvedlabel is present, it's treated as approved.Unpaused execution nodes proceed without signal: When a checkpoint is patched to skip a gate (e.g.,
current_node=generate_spec, is_paused=false), the workflow would still refuse to run because_handle_resume_eventrequired a signal. Now, non-gate execution nodes withis_paused=falseare allowed to proceed. Gate nodes and CI-waiting nodes still require explicit signals.Test plan
current_node=generate_spec is_paused=false— verify next event triggers executionci_evaluator— verify workflow does NOT auto-proceed (requires completed check)🤖 Generated with Claude Code