fix: preserve all PRD sections during revision#64
Open
ekuris-redhat wants to merge 1 commit into
Open
Conversation
ekuris-redhat
force-pushed
the
fix/prd-executive-summary-preserved-on-revision
branch
from
4cbc65d to
314b9e7
Compare
_strip_preamble checked text.find("\n#") before text.startswith("#").
When the LLM revision output started with "## 1. Executive Summary"
(no document title), the method found "\n## 2. Problem Statement" and
stripped everything before it — including the entire Executive Summary.
Fix: check startswith("#") first so content that already begins with a
heading is never stripped.
Also strengthened the shared regenerate.md prompt with explicit
preservation rules ("Preserve what was not objected to") for all
content types (PRD, spec, epic, task).
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
ekuris-redhat
force-pushed
the
fix/prd-executive-summary-preserved-on-revision
branch
from
314b9e7 to
376700f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
_strip_preamblecheckedtext.find("\n#")beforetext.startswith("#"). When the LLM revision output started with## 1. Executive Summary(no document title), the method found\n## 2. Problem Statementand stripped everything before it — including the entire Executive Summary.startswith("#")first so content that already begins with a heading is never stripped.regenerate.mdprompt with explicit preservation rules for all content types (PRD, spec, epic, task).Changes (3 files)
src/forge/integrations/agents/agent.py_strip_preamble: checkstartswith("#")beforefind("\n#")src/forge/prompts/v1/regenerate.mdtests/unit/prompts/test_prompt_templates.pyTest plan
_strip_preamblefix only):🤖 Generated with Claude Code