fix: post Jira comment when workflow nodes fail#58
Open
eshulman2 wants to merge 2 commits into
Open
Conversation
Nodes that hit errors set last_error in state but never notify the user on Jira — the failure is only visible in worker logs. Added centralized error reporting in the worker: after every workflow invocation, if last_error is set the worker posts a comment to the Jira ticket with the error details and retry instructions. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
9fb39a7 to
bcea49a
Compare
The container name was deterministic per ticket per PID, causing name collisions when multiple containers run for the same ticket in sequence (e.g., RCA → reflection → RCA). The third container would fail to start because the name was already taken. Use a UUID suffix instead. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When a workflow node fails (container crash, API error, etc.), the error was only logged to the worker console — users had no visibility on the Jira ticket. This adds centralized error reporting: after every workflow invocation, if
last_erroris set, the worker posts a comment to Jira with the error details and retry instructions.Changes
src/forge/orchestrator/worker.py: Added_post_error_to_jira()method, called after everyainvoke()whenlast_erroris set and the workflow isn't paused. Covers all 13 nodes that setlast_errorwithout any per-node changes.Test plan
🤖 Generated with Claude Code